Skip to content

fix(agent-manager): handle unanswered update questions - #13774

Merged
marius-kilocode merged 1 commit into
mainfrom
fix-slash-command-with-unanswered-question
Sep 4, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
fix-slash-command-with-unanswered-question

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

/update-from-base surfaced an internal Agent Manager blocker error when the target session had an unanswered question.

Why This Change Was Made

Treat this explicit user action as a follow-up prompt that can dismiss target questions through the backend queue, while preserving permission blockers and agent-to-agent question requirements.

User Impact

Update from base proceeds when only unanswered questions are pending. Pending permissions still block the update.

Evidence

  • 145 focused Agent Manager tests pass
  • Extension lint passes
  • Markdown table and diff checks pass
  • Typecheck/build are currently blocked by pre-existing workspace dependency and SDK type mismatches

@kilo-code-bot

kilo-code-bot Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .changeset/update-from-base-questions.md
  • packages/kilo-vscode/src/agent-manager/base-update.ts
  • packages/kilo-vscode/src/agent-manager/orchestration-domain.ts
  • packages/kilo-vscode/tests/unit/base-update.test.ts

Reviewed by grok-4.6 · Input: 187.4K · Output: 11.2K · Cached: 678.4K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 103baab into main Sep 4, 2026
25 checks passed
@marius-kilocode
marius-kilocode deleted the fix-slash-command-with-unanswered-question branch September 4, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants