Skip to content

fix(agent-manager): show completed status for review suggestions - #13743

Merged
marius-kilocode merged 2 commits into
mainfrom
fix-suggestion-completion-status
Sep 3, 2026
Merged

marius-kilocode merged 2 commits into
mainfrom
fix-suggestion-completion-status

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

What Problem This Solves

A session that ends its work with a review suggestion shows the review banner but keeps the normal worktree icon instead of the green Done indicator.

Why This Change Was Made

The suggest tool sets the session to idle while it waits for acceptance or dismissal. It has not emitted a completed-turn event at that point. Treat the pending suggestion as completion for the owning session's status indicator without changing the backend lifecycle or creating a false turn-close event.

User Impact

Idle sessions with a pending review suggestion now show Done. Busy, retry, error, and blocking-input states still take priority. Real terminal outcomes and acknowledgements override stale suggestion entries. A child session's suggestion does not mark its parent as done. The suggestion-based indicator clears when the suggestion resolves.

Evidence

  • The regression tests cover the real busy-to-suggestion-to-idle sequence without a sessionTurnClosed event, suggestion resolution, ownership, and status priority. All 29 focused tests pass.
  • Extension typecheck, lint, compile, Knip, and the Kilo-change guard pass.
  • Both screenshots use the same synthetic session and pending-suggestion events in isolated VS Code. The before build uses unchanged main source; the after build includes this fix. This verifies rendering without making a model request.

Before: the review banner is visible, but the worktree has the normal branch icon.

Before: a pending review suggestion leaves the Agent Manager worktree without a Done indicator

After: the same pending review suggestion shows the green Done indicator.

After: the same pending review suggestion shows a green Done indicator in Agent Manager

@kilo-code-bot

kilo-code-bot Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • .changeset/suggestion-completion-status.md
  • packages/kilo-vscode/tests/fixtures/session-provider-activity.tsx
  • packages/kilo-vscode/tests/unit/session-activity.test.ts
  • packages/kilo-vscode/webview-ui/src/context/session.tsx
  • packages/kilo-vscode/webview-ui/src/utils/session-activity.ts

Reviewed by grok-4.6 · Input: 228.5K · Output: 14.8K · Cached: 908.4K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit b9b92fb into main Sep 3, 2026
25 checks passed
@marius-kilocode
marius-kilocode deleted the fix-suggestion-completion-status branch September 3, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants