Repository navigation
fix(agent-manager): show completed status for review suggestions - #13743
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 228.5K · Output: 14.8K · Cached: 908.4K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 3, 2026 11:18
chrarnoldus
approved these changes
Sep 3, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A session that ends its work with a review suggestion shows the review banner but keeps the normal worktree icon instead of the green Done indicator.
Why This Change Was Made
The
suggesttool sets the session to idle while it waits for acceptance or dismissal. It has not emitted a completed-turn event at that point. Treat the pending suggestion as completion for the owning session's status indicator without changing the backend lifecycle or creating a false turn-close event.User Impact
Idle sessions with a pending review suggestion now show Done. Busy, retry, error, and blocking-input states still take priority. Real terminal outcomes and acknowledgements override stale suggestion entries. A child session's suggestion does not mark its parent as done. The suggestion-based indicator clears when the suggestion resolves.
Evidence
sessionTurnClosedevent, suggestion resolution, ownership, and status priority. All 29 focused tests pass.Before: the review banner is visible, but the worktree has the normal branch icon.
After: the same pending review suggestion shows the green Done indicator.