Repository navigation
refactor(vscode): share question resolution routing - #13739
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 143K · Output: 6.5K · Cached: 201.7K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 3, 2026 10:45
iscekic
approved these changes
Sep 3, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Question reply and reject handlers duplicate origin-directory routing, recovery, one-time retry, route cleanup, and error signaling. Separate implementations can drift when one path changes.
Why This Change Was Made
Extract one private question-only resolution helper with an endpoint callback and operation label. Keep the public signatures, operation-specific logs, and existing recovery scan unchanged. Retry only when recovery finds a different directory. An incomplete scan must not prove staleness; stale requests still return false, and failures remain retryable. Permission handling stays separate because its save-always-rules ordering and stale/error behavior differ.
User Impact
No intended behavior change. Replies and dismissals retain their original session and request-directory routing. The change removes 15 production lines and 10 total lines, including a small same-directory recovery regression case.
Evidence
Manual verification: reply to and dismiss worktree questions after switching sessions; verify the correct session continues. Stale questions should clear, while temporary failures must leave questions available for retry.