Repository navigation
refactor(agent-manager): clarify terminal restoration guards - #13726
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 44.1K · Output: 6.5K · Cached: 329.7K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 3, 2026 07:48
WebReflection
approved these changes
Sep 3, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the guard-order review on #13715, which is already merged.
Put the rejection guard before the terminal-selection return and reuse one remembered-terminal lookup. Preserve both required behaviors: missing tab memory must still fall back to an existing terminal, and a remembered terminal must still win when the context also has chat tabs. The suggested unconditional
!rememberedand!emptychecks would prevent those cases.Extend the existing Local/worktree regression cases to cover a remembered terminal alongside chat sessions. This is a behavior-preserving refactor, so no additional release note or UI change is needed.
Validation: 58 focused tests passed; extension/webview typechecks, lint, formatting, and the Kilo marker guard passed. No additional manual UI run was needed for this small internal refactor.