Repository navigation
(janitor/dead-code): remove unused auth components - #8998
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
Delete AccountTypeChoice and SyncSignInHint, two superseded auth components with no remaining references in the repository. AccountTypeChoice was replaced by AccountCreationScreen (rendered from app/account-verification/page.tsx). SyncSignInHint was replaced by SignInHintEmailSyncer (rendered from Providers.tsx). Neither file is imported, dynamically loaded, exported through a barrel, or referenced by any route, test, story, script, or configuration.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryDeletion-only PR removing two auth components; repo-wide search finds no remaining static or dynamic references to Assumptions: Files Reviewed (2 files)
Reviewed by deepseek-flash-latest · Input: 23.2K · Output: 1.5K · Cached: 133.8K Review guidance: REVIEW.md from base branch |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was deleted
Two superseded, unreferenced React components in
apps/web/src/components/auth/:AccountTypeChoice.tsx— a "choose Individual vs Team" onboarding card.SyncSignInHint.tsx— a sign-in hint persistence side-effect component.Both were replaced by active counterparts:
AccountTypeChoice→AccountCreationScreen(rendered fromapp/account-verification/page.tsx).SyncSignInHint→SignInHintEmailSyncer(rendered fromcomponents/Providers.tsx).Evidence they are unreachable
Repository-wide searches for the exact symbols
AccountTypeChoiceandSyncSignInHint(case-sensitive) across every file — source, tests, stories, docs, JSON, and config — match only each file's ownexportdeclaration. The same searches against the primary external consumer clone (Kilo-Org/kilocode) return zero matches.knip(the repo's configured dead-code tool) also reports both as unused files.Entry points checked
rgacross the whole repo, including@/alias, relative, and barrel imports).import(...)orrequire(...)references these paths.page/route/layout/loading/errorconvention file; both live undersrc/components/and there is noindexbarrel insrc/components/auth/..stories.*reference either component.jest.mock, or snapshot references either component.package.json, scripts, or configuration.Contract & compatibility considerations
apps/web(no package exports, no SDK/CLI surface, not published — the workspace package isprivate).null, the other is presentational UI).useSignInHint,KiloCardLayout,ui/card,ui/button,motion,lucide-react) remain used by other active components.Validation performed
tsgo --noEmit -p apps/web/tsconfig.json— passes (exit 0).oxlint --config .oxlintrc.json apps/web/src/components/auth— passes (exit 0).knip— both files no longer reported; no new orphans introduced (the deleted files were leaves with no dependents).git diff --check— clean.rgfor both symbols returns no remaining references.