Skip to content

(janitor/dead-code): remove unused auth components - #8998

Open
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
janitor/dead-code-unused-auth-components
Open

kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
janitor/dead-code-unused-auth-components

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

What was deleted

Two superseded, unreferenced React components in apps/web/src/components/auth/:

  • AccountTypeChoice.tsx — a "choose Individual vs Team" onboarding card.
  • SyncSignInHint.tsx — a sign-in hint persistence side-effect component.

Both were replaced by active counterparts:

  • AccountTypeChoice → AccountCreationScreen (rendered from app/account-verification/page.tsx).
  • SyncSignInHint → SignInHintEmailSyncer (rendered from components/Providers.tsx).

Evidence they are unreachable

Repository-wide searches for the exact symbols AccountTypeChoice and SyncSignInHint (case-sensitive) across every file — source, tests, stories, docs, JSON, and config — match only each file's own export declaration. The same searches against the primary external consumer clone (Kilo-Org/kilocode) return zero matches. knip (the repo's configured dead-code tool) also reports both as unused files.

Entry points checked

  • Static imports: none (rg across the whole repo, including @/ alias, relative, and barrel imports).
  • Dynamic imports / lazy loading: no import(...) or require(...) references these paths.
  • Next.js file conventions: neither file is a page/route/layout/loading/error convention file; both live under src/components/ and there is no index barrel in src/components/auth/.
  • Storybook: no .stories.* reference either component.
  • Tests: no test, jest.mock, or snapshot references either component.
  • Scripts / CI / config: no reference in package.json, scripts, or configuration.
  • Cloudflare bindings / Durable Objects / queues / cron: not applicable — these are client-only React components with no Worker wiring.

Contract & compatibility considerations

  • The files are internal to apps/web (no package exports, no SDK/CLI surface, not published — the workspace package is private).
  • Neither component performs module-level side effects; both are pure React components (one returns null, the other is presentational UI).
  • No persisted data, migrations, or rollback paths depend on them.
  • Deleting them orphans nothing: shared dependencies they import (useSignInHint, KiloCardLayout, ui/card, ui/button, motion, lucide-react) remain used by other active components.

Validation performed

  • tsgo --noEmit -p apps/web/tsconfig.json — passes (exit 0).
  • oxlint --config .oxlintrc.json apps/web/src/components/auth — passes (exit 0).
  • Re-ran knip — both files no longer reported; no new orphans introduced (the deleted files were leaves with no dependents).
  • git diff --check — clean.
  • Final rg for both symbols returns no remaining references.

Delete AccountTypeChoice and SyncSignInHint, two superseded auth
components with no remaining references in the repository.

AccountTypeChoice was replaced by AccountCreationScreen (rendered from
app/account-verification/page.tsx). SyncSignInHint was replaced by
SignInHintEmailSyncer (rendered from Providers.tsx). Neither file is
imported, dynamically loaded, exported through a barrel, or referenced
by any route, test, story, script, or configuration.
@kilo-code-bot kilo-code-bot Bot added the janitor Automated dead-code/duplication cleanup label Oct 28, 2026
@kilo-code-bot
kilo-code-bot Bot enabled auto-merge October 28, 2026 07:55
@kilo-code-bot

kilo-code-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Deletion-only PR removing two auth components; repo-wide search finds no remaining static or dynamic references to AccountTypeChoice or SyncSignInHint, and shared dependencies (useSignInHint, KiloCardLayout, UI primitives) are still used by active components.

Assumptions: [INFERENCE] The external Kilo-Org/kilocode consumer clone claimed in the PR description was not available for inspection; only this repository was verified. Deleted lines cannot receive inline comments, so any finding would have been summary-only.

Files Reviewed (2 files)
  • apps/web/src/components/auth/AccountTypeChoice.tsx - deleted, 0 issues
  • apps/web/src/components/auth/SyncSignInHint.tsx - deleted, 0 issues

Reviewed by deepseek-flash-latest · Input: 23.2K · Output: 1.5K · Cached: 133.8K

Review guidance: REVIEW.md from base branch main

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

janitor Automated dead-code/duplication cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants