Repository navigation
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe change adds a narrowly anchored duration-limit pattern to the existing timeout branch and a matching regression pair; I found no bugs, security concerns, or behavioral regressions in the two changed files. Assumptions: Files Reviewed (2 files)
Reviewed by deepseek-flash-latest · Input: 57.5K · Output: 7.6K · Cached: 756.2K Review guidance: REVIEW.md from base branch |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classifyAssistantFailureTexttimeout branch. The duration is numeric rather than hardcoded to 600 seconds.UnknownErrorwith a JSON envelope indata.messageastimeout, reusing the existingAssistant request timed outsafe message.timeouts, which remainsunknown/Assistant request failed.error_typeorigin precedence, existing safe messages, other reason mappings, and interrupt handling. No UI, gateway, wrapper, dependency, retry, or budget changes.Verification
No manual, browser, or live gateway tests were run. This is a pure classifier change verified with local automated tests; a unit test does not exercise the live gateway path.
Automated Checks
pnpm --filter cloud-agent-next test src/session/safe-failure-projection.test.tsfailed exactly the new observed-envelope regression: receivedunknown/Assistant request failed; 313 other tests passed, including the new negative case.pnpm --filter cloud-agent-next test src/session/safe-failure-projection.test.ts: all 314 tests passed, including existing structured-origin precedence and interrupt coverage.pnpm --filter cloud-agent-next typecheck: passed, including the package-script wrapper typecheck.pnpm --filter cloud-agent-next lint: passed.pnpm format services/cloud-agent-next/src/shared/assistant-failure.ts services/cloud-agent-next/src/session/safe-failure-projection.test.ts: passed.git diff --checkandgit diff --check origin/main...HEAD: passed.Visual Changes
N/A. No UI changes.
Reviewer Notes
timeoutsor generic duration-limit text. Future gateway copy changes may require updating this fallback. Recognized structured gateway origins remain authoritative.