Repository navigation
(janitor/comments) remove narrating and restating comments from cloud-agent chat module - #8933
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
…-agent chat module Delete section banners, restating doc blocks, field restatements, and control-flow narration from the cloud-agent chat types, session config, message rendering, and session store. Keep all constraint, contract, and platform-behavior comments. Comment-only change.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryComment-only cleanup of six Assumptions: Files Reviewed (6 files)
Reviewed by deepseek-flash-latest · Input: 46.9K · Output: 2.7K · Cached: 286K Review guidance: REVIEW.md from base branch |
|
Note on the failing The 2 failures ( Evidence:
Suggested fix (for the #7874 author/maintainer): add |
Package / topic area cleaned
apps/web/src/components/cloud-agent/— the cloud-agent chat module (chat message types, session-config derivation, message content rendering, session store atoms, org models hook).Files touched
apps/web/src/components/cloud-agent/types.tsapps/web/src/components/cloud-agent/session-config.tsapps/web/src/components/cloud-agent/MessageContent.tsxapps/web/src/components/cloud-agent/store/db-session-atoms.tsapps/web/src/components/cloud-agent/store/session-form-atoms.tsapps/web/src/components/cloud-agent/hooks/useOrganizationModels.tsComment lines removed
177 comment lines (184 deleted lines total, 7 of which are code lines whose trailing comment was removed; 9 blank separator lines went with their blocks).
Categories of noise removed
// ====...====blocks intypes.ts,session-form-atoms.ts)User message,Zod schema for StoredSession,Options for building a session config, …)// Message role,// Tool input parameters,// LLM model identifier, …)@param/@returnsrestatements and usage@examplenarration (buildSessionConfig)// Check dbSession first,// Prepend to existing sessions,// Convert DB's updated_at to milliseconds,// Completed successfully, …)// Default: regular text message)Important comments intentionally retained
types.tsheader: no-imports circular-dependency invariant;AgentModesharing note;tsas unique message ID;textvscontent"stream uses both"; say/ask subtype value domains;KilocodeEventstdout passthrough;streamEventTypediscriminator rationalesession-config.ts: re-export compatibility note;sendMessageStreamschema contract; field precedence notesMessageContent.tsx: CLI-mimicking behavior note; "all fields except 'tool' are input parameters"; empty-output-means-complete semanticsdb-session-atoms.ts: client-side-only warning and architecture header; high-water-mark staleness rules (incl. "don't use Math.max" and 2-second tolerance); org-context version >= 2 reliability rule; "CRITICAL" session-ID routing constraints; all catch-block intent commentsuseOrganizationModels.ts: org access-policy noteFollow-up refactor candidates
getModeModelWithSourceinsession-config.tspartially duplicatesbuildSessionConfigprecedence logic.db-session-atoms.ts(processIncomingMessageAtom/appendMessageToSessionAtom).Validation performed
oxfmt --checkon all touched files: cleanpnpm run lint(apps/web oxlint): passpnpm run typecheck(apps/web tsgo): passAuto-merge: set to merge automatically on approval.