Repository navigation
feat(cloud-agent): scope split images to interactive org sessions - #8903
Conversation
6bca551 to
b716978
Compare
…l runtime publication Add an org-scoped downloaded/runtime-free startup target for interactive web routes on isolated native containers, allow manual runtime publication for an exact main SHA, and keep every committed runtime target on preinstalled all-in-one images.
b716978 to
7c98066
Compare
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commit changes only Assumptions: Files Reviewed (1 file, 5 changed lines)
Previous Review Summaries (2 snapshots, latest commit 4ad83d3)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 4ad83d3)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryBoth previously reported findings still reproduce on current HEAD: deploy jobs retain the publisher's write-capable R2 credentials plus the account-wide Assumptions: Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (12 incremental files)
Carried forward after current-code verification (files outside the incremental diff): Previous review (commit 7c98066)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe org-scoped startup selection, image plumbing, provenance persistence, and manual publication admission are consistent with the documented design; the issues are a least-privilege regression in runtime publication credentials and a rollout gap where runtime-free cohort containers cannot restore environment-builder snapshots. Assumptions: Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (30 files)
Reviewed by deepseek-flash-latest · Input: 33.9K · Output: 4.6K · Cached: 271.1K Review guidance: REVIEW.md from base branch |
…nt provenance Drop the persisted clientProvenance field so a Worker rollback can still parse stored routes, and apply the interactive org cohort to Vercel startup as well.
Summary
clientProvenance: browser). Other sessions keep the all-in-oneappimage.workflow_dispatch) for an exactmainSHA that has a trusted CI push run. This lets us publish split images to R2 and the registry without changing what production runs. Replaces ci(cloud-agent): allow manual runtime publication from main #8968.mainsince feat(cloud-agent): add BYOC Vercel compute #8859. Persisted client provenance now acceptsagent-manager; onlybrowserqualifies for the cohort.runtime-targets.jsonkeeps every target on preinstalled/all-in-one. Production deploys do not depend on publication after this merges.Verification
main: worker and wrapper typecheck, 4935 unit tests, the Workers integration suite (26 files), andpnpm run test:runtime-ci(36 tests) passed.Visual Changes
N/A
Reviewer Notes
main. Test it after merge withgh workflow run cloud-agent-runtime-publish.yml --ref main -f source_sha=<main-sha>, then check the handoff object and thekilo-runtime-basedigest for that SHA.CLOUD_AGENT_RUNTIME_PUBLICATION_ENABLED=true.CLOUD_AGENT_RUNTIME_R2_*keys, and the publish job usesCLOUDFLARE_API_TOKEN. This is broader access than separate read-only and publish-only credentials.docs/runtime-rollout.md.