Repository navigation
(janitor/dependencies) Remove unused @storybook/test-runner devDependency - #8896
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryDependency-only removal of the unused Assumptions: Files Reviewed (2 files)
Reviewed by deepseek-flash-latest · Input: 57K · Output: 6.6K · Cached: 487.9K Review guidance: REVIEW.md from base branch |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a single high-confidence unused dependency from one workspace package:
@storybook/test-runner@kilocode/storybook(apps/storybook)0.24.4Evidence each dependency is unused
@storybook/test-runner(the Storybook/Playwright test runner, invoked via itstest-storybookbinary):test-runner,test-storybook, andtestStorybook(all file types, excludingnode_modules/lockfile) returns zero source references.apps/storybook/package.jsonhas notest-storybook(or any test) script; its scripts arestorybook,build-storybook,preview,chromatic,generate-screenshot-stories,component-inventory,typecheck,clean..storybook/test-runner.*, noplaywright.config.*in the storybook package, and it is not listed in.storybook/main.tsaddons or framework options..github/workflows/chromatic.ymlbuilds withpnpm build-storybookand runschromatic --exit-zero-on-changes; there is notest-storybookinvocation anywhere in.github.pnpm-lock.yamlit is a standalone direct devDependency of@kilocode/storybook; it is not a peer or optional peer of Chromatic (@chromatic-com/storybook) or any other dependency, and it is not a Storybook addon/preset/loader.git log -Sshows it was added wholesale in the monorepo restructure (#1315) and has never been referenced by any script, config, or CI workflow since.Dynamic, configuration, and tooling references checked
require/import/globby name, nostorybook-discovered addon, no config-schema discovery.apps/storybook/package.json,.storybook/main.ts,.storybook/preview.ts,.storybook/storybook.css,tailwind.config.js,postcss.config.mjs,apps/web/knip.tsworkspace entry,apps/mobile/knip.json..github/workflows/chromatic.yml,ci.yml,notify-main-failure.yml.knip --dependencies(run fromapps/web, which includes the storybook workspace) flags@storybook/test-runneras an unused devDependency, agreeing with the manual search.Package publication and peer-dependency considerations
@kilocode/storybookis"private": true; it is not published, so there is no published peer/optional-dependency contract to preserve.@storybook/test-runnerdeclares no peers that other packages rely on through this declaration.Validation performed
pnpm install --no-frozen-lockfileregenerated the lockfile (638 deletions: the package plus its exclusive transitive graph —nyc,expect-playwright,jest-serializer-html,jest-process-manager,wait-on,playwright-core, etc.).@sentry/react-native→metro-config@0.87.1re-keying) so the diff contains only the@storybook/test-runnerremoval (0 added lines).pnpm install --frozen-lockfile --offline→Already up to date(lockfile is consistent withpackage.json).pnpm --filter @kilocode/storybook typecheck(tsgo) → passes.pnpm --filter @kilocode/storybook build-storybook→ completes successfully.Uncertainty
knipalso flags@emotion/is-prop-valid,clsx, andtailwind-merge(dependencies) and@tailwindcss/typography(devDependency) in the same package. These were not removed because they are plausibly needed for webpack/hoisting resolution of components imported fromapps/web, or (for@tailwindcss/typography) referenced transitively via@plugin '@tailwindcss/typography'inapps/web/src/app/globals.csswhich storybook imports. They were left in place to avoid accidental reliance on transitive deps.knipflags@octokit/graphql-schema(web devDependency) as unused, but it is read off disk (node_modules/@octokit/graphql-schema/schema.json) inapps/web/src/routers/github-pr-review-graphql-schema.test.ts, so it was correctly not removed.