Repository navigation
fix(mobile): align Greek PR review terminology and merge request copy - #8842
Conversation
Use one Greek review term across the pull-request review surface and make the merge-request error copy match the catalog conventions. - prReview.review, overview.reviewers, overview.reviewPending and submit.submitReview now share the review term already used by the neighbouring review strings, so the visible Review button text is part of its accessibility label. - terms.couldNotLoadMergeRequest no longer ends with a full stop, like the other merge-request titles. - terms.unavailableDescription addresses the reader in the informal singular, matching the neighbouring error copy. - Extend the development-only PR review copy fixture with overview, submit and provider error surfaces so the copy can be read without a forge.
iscekic
added
drain
|
bot: Android emulator, Greek app language, head fd619cc. Development build from Metro on the work VM; the real overview, review-submit screen and provider error states mounted over development-only fake reads (no forge, no backend). Observed copy:
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
The checks fixture is only read from its own module, so it does not need to be exported.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe only change since the previous review is the native-intent fixture regex at Assumptions: Files Reviewed (5 files)
Previous Review Summary (commit e812911)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e812911)Status: No Issues Found | Recommendation: Merge Executive SummaryNo new issues in this run: the Greek catalog edits, the wording exception, and the dev-only fixture surfaces are consistent with the changed consumers; the earlier suggestion about fragment-only fixture links ( Assumptions: Files Reviewed (5 files)
Reviewed by deepseek-flash-latest · Input: 28.8K · Output: 1.9K · Cached: 145.4K Review guidance: REVIEW.md from base branch |
The pattern now accepts an optional fragment after the optional query, so a fragment-only link still opens the fixture and a link that carries both keeps its query.
|
bot: Captures re-taken at head b468911 (the earlier set was from fd619cc; the copy on screen is the same, and this set matches the current head). Same method: Android emulator, Greek app language, development build from Metro on the work VM, real overview, review-submit screen and provider error states over development-only fake reads. Observed in the view hierarchy at this head:
|
iscekic
added
the
merge:bot
Evidence
Evidence: demonstrated — on the Android emulator in Greek, the real pull-request review overview rendered «Αξιολόγηση», «Αξιολογητές» and «Σε αναμονή αξιολόγησης», the review-submit sheet rendered «Υποβολή αξιολόγησης», and a failing merge-request read rendered «Μη διαθέσιμο αίτημα συγχώνευσης» with the informal «μπορεί να μην έχεις πρόσβαση σε αυτό» and a load-error title without a trailing full stop. Current main (1568126) carries «Έλεγχος», «Ελεγκτές», «Σε αναμονή ελέγχου», «Υποβολή ελέγχου», the formal «έχετε» and the trailing full stop, read from the catalog at that commit.
Change
prReview.review,prReview.overview.reviewers,prReview.overview.reviewPendingandprReview.submit.submitReviewnow use the one Greek review term the surrounding review strings already use. The visible Review button text is therefore part of its accessibility label, and the reviewers heading and the pending-state label agree with the review-required state label.prReview.terms.couldNotLoadMergeRequestdrops its trailing full stop, matching the English title and the sibling merge-request title.prReview.terms.unavailableDescriptionaddresses the reader in the informal singular, like the neighbouring error copy.Verification
pnpm --filter kilo-app check:i18n— 87 catalogs matchen.json.pnpm --filter kilo-app exec vitest run src/i18n src/components/pr-review src/lib/pr-review— 155 files, 3111 tests pass.pnpm --filter kilo-app typecheck,lint,format:check— pass on the head commit.PrReviewOverview,PrReviewReviewSubmitScreenand provider error states over fake reads:Runtime boundary
Real components, hooks and i18next resolution with development-only fake reads. No forge traffic and no backend are involved; a live GitHub or GitLab read is not exercised by this change, which touches catalog values only.
Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: Extend the merged dev fixture with overview + GitLab error surfaces
Confidence: 0.78 · Precedent: Proof and verification: use fixtures for hard-to-capture states, dev-only, faithful and committed for reuse; fixture rules.
pnpm check:i18nenforces one Greek wording per identical English string. English "Review" is shared by this review flag, a code-reviewer settings title and an excluded-feature onboarding key that must not be touched. Changing onlyprReview.reviewtherefore fails the check. How should I resolve it?Answer: Add "Review" to the el wording exceptions
Confidence: 0.80 · Precedent: Product scope: never touch the excluded features; Git and PRs: keep each PR diff to files the feature needs, and CI must pass for human ready.