Repository navigation
fix(kilo-mcp): generate the skill area list without counts - #8639
Merged
Merged
Conversation
Two pull requests that each add a procedure both regenerate `.kilo/skills/kilo-mcp/SKILL.md` with different totals and row counts, so the second one to merge always conflicts on the generated file. The census now derives the sorted list of first path segments only: one bullet per area. Two pull requests that add procedures inside existing areas render byte-identical files, and a new area adds one line in a stable position. The per-area breakdown by second path segment is dropped for the same reason; one `kilo_search` answers that question with current data.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe generator, template, committed skill, and tests change coherently: the census is reduced to a deterministic sorted list of first path segments, the checked-in SKILL.md matches the committed catalog's 49 areas, and no other in-repo consumer used the removed Assumptions: Files Reviewed (4 files)
Reviewed by deepseek-flash-latest · Input: 61.1K · Output: 9K · Cached: 847.7K Review guidance: REVIEW.md from base branch |
iscekic
enabled auto-merge
October 22, 2026 17:04
eshurakov
approved these changes
Oct 22, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.kilo/skills/kilo-mcp/SKILL.mdis generated fromservices/kilo-mcp/catalog.json, and every pull request that changes the catalog regenerates it. The census carried totals, per-area counts and a second-segment breakdown, so two pull requests that each added a procedure produced different bytes for the same file. Whichever merged second conflicted.The census now derives one thing: the sorted list of first path segments, one bullet per area. No totals, no counts, no per-area breakdown.
Why this removes the conflict
kilo_searchand never to pick a path from this file. Area names still orient the reader.Verification
pnpm exec jest src/scripts/mcp-catalog/skill.test.tson a work VM with Postgres (17 tests, all pass). New tests pin "procedures added inside existing areas leave the skill byte-identical" and "a new area adds exactly one line".pnpm --filter web typecheck,oxlint, andoxfmt --list-differentclean on the changed files.Deploy notes
None. The generator, its template, and its tests change together, and CI regenerates the file from the catalog as before.