Repository navigation
fix(ci): evaluate the release build config as the production profile - #8578
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Reviewed by deepseek-flash-latest · Input: 50K · Output: 15.7K · Cached: 652.4K Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Oct 22, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every mobile release run since the Artifacts File Provider work merged fails in
build-and-submitbefore any artifact exists:app.config.tsandplugins/withArtifactFileProvider.jsgate the dev-onlycom.apple.developer.fileprovider.testing-modeentitlement onEAS_BUILD_PROFILE === 'production'. TheBuild iOS and Androidstep sets onlyEXPO_TOKEN, so the eas-cli evaluation ofapp.config.ts— the one whoseentitlements it syncs onto the App IDs — ran as non-production, put the dev-only
entitlement in the extension's EAS entry, and asked Apple to enable a capability
a release must not carry. Apple rejected the sync and the whole
eas buildcommand exited 1, so that run lost its iOS and Android artifacts.
Change
Run the release build through
eas env:exec production, the same mechanism thepreflight assertion already uses, so the CLI evaluates the production profile:
EAS_BUILD_PROFILE=productionmakes the CLI evaluation match the builder's.asserts, so a bare
EAS_BUILD_PROFILEalone would throw.SENTRY_AUTH_TOKENis a SECRET variable only a builder can read, so theevaluation gets the placeholder the preflight step already uses.
Verification
preflightis green on the failing commit and already runsenv:exec production --non-interactive 'EAS_BUILD_PROFILE=production SENTRY_AUTH_TOKEN=preflight-placeholder pnpm assert:config', so the productionevaluation with that placeholder passes on
main.env:exec --non-interactiveis a pure passthrough (spawn(shell: true, stdio: 'inherit')), so the redirection and the exit status of the innercommand are unchanged.
must show no testing-mode capability patch, and the run must reach artifact
download.