Repository navigation
fix(repo): restore the green main checks - #8510
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commits only tighten two AI-gateway test helpers to satisfy the type-aware Assumptions: Files Reviewed (2 files)
The earlier Previous Review Summary (commit 082079e)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 082079e)Status: No Issues Found | Recommendation: Merge Executive SummaryThe PR regenerates Assumptions: Files Reviewed (1 file)
Verification notes:
No inline comments posted: lockfile is a generated artifact and the changes are coherent. Reviewed by deepseek-flash-latest · Input: 31.1K · Output: 2.7K · Cached: 272K Review guidance: REVIEW.md from base branch |
mainis red on every workflow. Two independent causes, both fixed here.1. Broken lockfile
Every workflow aborts at the dependency install step:
snapshotslistsjest-worker@30.5.1with@ungap/structured-clone: 1.3.0, butpackagesonly resolved that module at a different version.Fix: regenerated
pnpm-lock.yamlwithpnpm install --no-frozen-lockfile --ignore-scripts. No manual edits and no side-selection. The diff is limited to the inconsistent entries: it repoints thejest-worker@30.5.1snapshot, adds the missing optional@emnapiand@napi-rs/wasm-runtimeentries, and aligns one@sentry/react-nativepeer resolution.2. Lint group
restThe type-aware rules in
web-sharedreject threeString(...)calls that stringify values typed asobject:packages/web-shared/src/lib/ai-gateway/openai-chatgpt/refresh-terminal-race.test.tsstringifiedRequestInit.body; it now reads the form field the request actually sends.packages/web-shared/src/lib/ai-gateway/providers/upstream-request.aws-bedrock.test.tsstringified the fetch input and body; it now narrows both explicitly and fails loudly on an unexpected body type.Both are test-file changes; no production code changed.
Verification
pnpm --filter kilocode-monorepo install --frozen-lockfile --ignore-scriptsfails with the error above. After the commit: the same command installs the workspace and exits successfully.scripts/lint-all.sh --group restwith a full affected set: 0 warnings, 0 errors, after reporting 3 errors before the change.jeston both touched suites against a migrated database: 2 suites, 4 tests passed.pnpm --filter @kilocode/web-shared typecheck: passes.pnpm-lock.yamland the two test files.