Skip to content

fix(repo): restore the green main checks - #8510

Merged
iscekic merged 2 commits into
mainfrom
fix/broken-lockfile-entry
Oct 21, 2026
Merged

iscekic merged 2 commits into
mainfrom
fix/broken-lockfile-entry

Conversation

@iscekic

@iscekic iscekic commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

main is red on every workflow. Two independent causes, both fixed here.

1. Broken lockfile

Every workflow aborts at the dependency install step:

[ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY] Broken lockfile: no entry for '@ungap/structured-clone@1.3.0' in pnpm-lock.yaml

snapshots lists jest-worker@30.5.1 with @ungap/structured-clone: 1.3.0, but packages only resolved that module at a different version.

Fix: regenerated pnpm-lock.yaml with pnpm install --no-frozen-lockfile --ignore-scripts. No manual edits and no side-selection. The diff is limited to the inconsistent entries: it repoints the jest-worker@30.5.1 snapshot, adds the missing optional @emnapi and @napi-rs/wasm-runtime entries, and aligns one @sentry/react-native peer resolution.

2. Lint group rest

The type-aware rules in web-shared reject three String(...) calls that stringify values typed as object:

  • packages/web-shared/src/lib/ai-gateway/openai-chatgpt/refresh-terminal-race.test.ts stringified RequestInit.body; it now reads the form field the request actually sends.
  • packages/web-shared/src/lib/ai-gateway/providers/upstream-request.aws-bedrock.test.ts stringified the fetch input and body; it now narrows both explicitly and fails loudly on an unexpected body type.

Both are test-file changes; no production code changed.

Verification

  • Clean checkout, before the first commit: pnpm --filter kilocode-monorepo install --frozen-lockfile --ignore-scripts fails with the error above. After the commit: the same command installs the workspace and exits successfully.
  • scripts/lint-all.sh --group rest with a full affected set: 0 warnings, 0 errors, after reporting 3 errors before the change.
  • jest on both touched suites against a migrated database: 2 suites, 4 tests passed.
  • pnpm --filter @kilocode/web-shared typecheck: passes.
  • Diff touches only pnpm-lock.yaml and the two test files.

@kilo-code-bot

kilo-code-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental commits only tighten two AI-gateway test helpers to satisfy the type-aware String(object) lint rule, and both replacements match what the production code actually sends.

Assumptions: [INFERENCE] Tests were not executed in this read-only review; correctness was verified statically against postRefreshRequest (form-urlencoded URLSearchParams.toString() body, key refresh_token) and upstreamRequest (fetch(outgoing.url, {...})), and both new assertions preserve the original test intent.

Files Reviewed (2 files)
  • packages/web-shared/src/lib/ai-gateway/openai-chatgpt/refresh-terminal-race.test.ts - 0 issues; the string narrowing is valid because refresh.ts:149 sends URLSearchParams.toString(), and parsing it back checks the exact field.
  • packages/web-shared/src/lib/ai-gateway/providers/upstream-request.aws-bedrock.test.ts - 0 issues; the string | URL | Request narrowing is exhaustive for the declared RequestInfo | URL mock parameter.

The earlier pnpm-lock.yaml change was reviewed at 082079e0 with no findings and is unchanged by these commits.

Previous Review Summary (commit 082079e)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 082079e)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The PR regenerates pnpm-lock.yaml to restore the missing jest-worker@30.5.1 dependency entry, and the resulting entries are internally consistent on inspection.

Assumptions: [INFERENCE] I did not run pnpm install --frozen-lockfile (read-only review), so install success is taken from the PR description and cross-checked statically: every changed dependency target now resolves to an existing packages/snapshots entry.

Files Reviewed (1 file)
  • pnpm-lock.yaml

Verification notes:

  • pnpm-lock.yaml:36138 now pins @ungap/structured-clone: 1.4.0 for jest-worker@30.5.1, and 1.4.0 is the only version present in both packages and snapshots, matching all other references.
  • New @emnapi/core@1.10.0, @emnapi/runtime@1.10.0, and @napi-rs/wasm-runtime@1.1.6(@emnapi/core@1.10.0)(@emnapi/runtime@1.10.0) snapshots are referenced by @unrs/resolver-binding-wasm32-wasi@1.12.2, and their own dependencies (@emnapi/wasi-threads@1.2.1, @tybys/wasm-util@0.10.3, tslib@2.8.1) exist.
  • The @sentry/react-native importer/snapshot peer id now uses the plain metro-config@0.84.5 resolution id, consistent with the plain packages entry, while its dependency remains the peer-suffixed snapshot.

No inline comments posted: lockfile is a generated artifact and the changes are coherent.


Reviewed by deepseek-flash-latest · Input: 31.1K · Output: 2.7K · Cached: 272K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic changed the title fix(repo): restore the missing lockfile entry for jest-worker fix(repo): restore the green main checks Oct 21, 2026
@iscekic
iscekic enabled auto-merge October 21, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants