fix(mobile): show a no-access state for an organization the reader lost

apps/mobile/src/components/code-reviewer/platform-list-screen.mounted.test.tsx

@@ -0,0 +1,179 @@
+// The Code Reviewer scope landing shares the Profile row's scope resolution, so
+// an organization the reader may not see must reach the no-access surface
+// instead of three platform rows whose status reads "unavailable".
+
+import { type ComponentType, createElement, type ReactNode } from 'react';
+import { act, TestRenderer } from '@/test/renderer';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+
+import '@/i18n';
+import { PlatformListScreen } from './platform-list-screen';
+
+const refetchMocks = vi.hoisted(() => ({
+  list: vi.fn<() => void>(),
+  github: vi.fn<() => void>(),
+  gitlab: vi.fn<() => void>(),
+  bitbucket: vi.fn<() => void>(),
+}));
+const membership = vi.hoisted(() => ({
+  organizations: [] as { organizationId: string; organizationName: string }[],
+}));
+const status = vi.hoisted(() => ({ error: undefined as unknown }));
+
+const denial = { data: { code: 'UNAUTHORIZED', httpStatus: 401 } };
+
+function statusResult(refetch: () => void) {
+  return {
+    data: status.error ? undefined : { connected: false },
+    isLoading: false,
+    isError: status.error !== undefined,
+    isFetching: false,
+    error: status.error,
+    refetch,
+  };
+}
+
+vi.mock('@/lib/hooks/use-code-reviewer', () => ({
+  PERSONAL_SCOPE: 'personal',
+  useGitHubStatus: () => statusResult(refetchMocks.github),
+  useGitLabStatus: () => statusResult(refetchMocks.gitlab),
+  useBitbucketReadiness: () => statusResult(refetchMocks.bitbucket),
+}));
+
+vi.mock('@tanstack/react-query', () => ({
+  useQuery: () => ({
+    data: membership.organizations,
+    isFetching: false,
+    refetch: refetchMocks.list,
+  }),
+}));
+
+vi.mock('expo-router', () => ({ useRouter: () => ({ push: vi.fn(), replace: vi.fn() }) }));
+
+vi.mock('@/lib/trpc', () => ({
+  useTRPC: () => ({
+    organizations: { list: { queryOptions: () => ({ queryKey: ['organizations', 'list'] }) } },
+  }),
+}));
+
+vi.mock('@/components/organization/scope-access-denied-screen', () => ({
+  ScopeAccessDeniedScreen: (props: {
+    title?: string;
+    eyebrow?: string;
+    kind?: string;
+    onRetry?: () => void;
+  }) => createElement('ScopeAccessDeniedScreenMock', props),
+}));
+
+vi.mock('@/components/screen-header', () => ({
+  ScreenHeader: (props: { title?: string; eyebrow?: string }) =>
+    createElement('ScreenHeaderMock', { title: props.title, eyebrow: props.eyebrow }),
+}));
+
+vi.mock('@/components/ui/configure-row', () => ({
+  ConfigureRow: (props: { title?: string }) =>
+    createElement('ConfigureRowMock', { title: props.title }),
+}));
+
+vi.mock('@/components/ui/text', () => ({
+  Text: (props: { children?: ReactNode }) => createElement('TextMock', null, props.children),
+}));
+
+vi.mock('@/components/tab-screen', () => ({ TabScreenScrollView: 'TabScreenScrollView' }));
+vi.mock('@/components/ui/icons', () => ({
+  CirclePlus: 'CirclePlus',
+  GitBranch: 'GitBranch',
+  GitMerge: 'GitMerge',
+  GitPullRequest: 'GitPullRequest',
+  History: 'History',
+}));
+vi.mock('react-native', () => ({ View: 'View' }));
+
+const Screen = PlatformListScreen as ComponentType<{ scope: string }>;
+
+function mountScreen(scope = 'org-lost'): TestRenderer.ReactTestRenderer {
+  const ref: { current: TestRenderer.ReactTestRenderer | undefined } = { current: undefined };
+  act(() => {
+    ref.current = TestRenderer.create(createElement(Screen, { scope }));
+  });
+  if (!ref.current) {
+    throw new Error('platform list did not render');
+  }
+  return ref.current;
+}
+
+function findByType(root: TestRenderer.ReactTestInstance, type: string) {
+  return root.findAll(node => typeof node.type === 'string' && node.type === type);
+}
+
+beforeEach(() => {
+  status.error = undefined;
+  membership.organizations = [{ organizationId: 'org-lost', organizationName: 'Drain Labs' }];
+  for (const refetch of Object.values(refetchMocks)) {
+    refetch.mockReset();
+  }
+});
+
+describe('PlatformListScreen organization access', () => {
+  it('renders the no-access surface instead of the platform rows when the scope is denied', () => {
+    status.error = denial;
+    const renderer = mountScreen();
+    const denied = findByType(renderer.root, 'ScopeAccessDeniedScreenMock')[0];
+
+    expect(denied?.props.kind).toBe('denied');
+    expect(denied?.props.title).toBe('Drain Labs');
+    expect(denied?.props.eyebrow).toBe('Code Reviewer');
+    expect(findByType(renderer.root, 'ConfigureRowMock')).toHaveLength(0);
+
+    act(() => {
+      renderer.unmount();
+    });
+  });
+
+  it('falls back to the generic organization title when the membership list no longer names it', () => {
+    status.error = denial;
+    membership.organizations = [];
+    const renderer = mountScreen();
+    const denied = findByType(renderer.root, 'ScopeAccessDeniedScreenMock')[0];
+
+    expect(denied?.props.title).toBe('Organization');
+
+    act(() => {
+      renderer.unmount();
+    });
+  });
+
+  it('re-reads the membership and every platform status on Retry', () => {
+    status.error = { data: { code: 'NOT_FOUND', httpStatus: 404 } };
+    const renderer = mountScreen();
+    const denied = findByType(renderer.root, 'ScopeAccessDeniedScreenMock')[0];
+    if (!denied) {
+      throw new Error('the no-access surface did not render');
+    }
+    expect(denied.props.kind).toBe('not-found');
+
+    act(() => {
+      (denied.props.onRetry as () => void)();
+    });
+
+    expect(refetchMocks.list).toHaveBeenCalledTimes(1);
+    expect(refetchMocks.github).toHaveBeenCalledTimes(1);
+    expect(refetchMocks.gitlab).toHaveBeenCalledTimes(1);
+    expect(refetchMocks.bitbucket).toHaveBeenCalledTimes(1);
+
+    act(() => {
+      renderer.unmount();
+    });
+  });
+
+  it('keeps the platform rows when access resolves', () => {
+    const renderer = mountScreen();
+
+    expect(findByType(renderer.root, 'ScopeAccessDeniedScreenMock')).toHaveLength(0);
+    expect(findByType(renderer.root, 'ConfigureRowMock').length).toBeGreaterThan(0);
+
+    act(() => {
+      renderer.unmount();
+    });
+  });
+});

apps/mobile/src/components/code-reviewer/platform-list-screen.tsx

@@ -4,6 +4,7 @@ import { CirclePlus, GitBranch, GitMerge, GitPullRequest, History } from '@/comp
 import { useTranslation } from 'react-i18next';
 import { View } from 'react-native';
 
+import { ScopeAccessDeniedScreen } from '@/components/organization/scope-access-denied-screen';
 import { ScreenHeader } from '@/components/screen-header';
 import { ConfigureRow } from '@/components/ui/configure-row';
 import { Text } from '@/components/ui/text';
@@ -16,6 +17,7 @@ import {
   useGitHubStatus,
   useGitLabStatus,
 } from '@/lib/hooks/use-code-reviewer';
+import { classifyOrganizationScopeAccess } from '@/lib/organization-scope-access';
 import { useTRPC } from '@/lib/trpc';
 
 const PLATFORM_ICONS = {
@@ -52,10 +54,11 @@ export function PlatformListScreen({ scope }: Readonly<{ scope: string }>) {
   const trpc = useTRPC();
   const isPersonal = scope === PERSONAL_SCOPE;
 
-  const { data: orgs } = useQuery({
+  const organizations = useQuery({
     ...trpc.organizations.list.queryOptions(),
     enabled: !isPersonal,
   });
+  const orgs = organizations.data;
   const scopeTitle = isPersonal
     ? t('common.personal')
     : (orgs?.find(org => org.organizationId === scope)?.organizationName ??
@@ -64,6 +67,39 @@ export function PlatformListScreen({ scope }: Readonly<{ scope: string }>) {
   const githubStatus = useGitHubStatus(scope);
   const gitlabStatus = useGitLabStatus(scope);
   const bitbucketReadiness = useBitbucketReadiness(scope);
+  const access = classifyOrganizationScopeAccess({
+    isOrganizationScope: !isPersonal,
+    errors: [githubStatus.error, gitlabStatus.error, bitbucketReadiness.error],
+  });
+
+  // Re-resolve membership and every platform status together: a restored
+  // membership must land the real rows, and a live installer account must not
+  // wait on a serially refreshed status.
+  const retryAccess = async () => {
+    await Promise.allSettled([
+      organizations.refetch(),
+      githubStatus.refetch(),
+      gitlabStatus.refetch(),
+      bitbucketReadiness.refetch(),
+    ]);
+  };
+
+  if (access !== 'granted') {
+    return (
+      <ScopeAccessDeniedScreen
+        title={scopeTitle}
+        eyebrow={t('common.codeReviewer')}
+        kind={access}
+        onRetry={() => void retryAccess()}
+        isRetrying={
+          organizations.isFetching ||
+          githubStatus.isFetching ||
+          gitlabStatus.isFetching ||
+          bitbucketReadiness.isFetching
+        }
+      />
+    );
+  }
 
   const statusFor = (platform: ReviewerPlatform) => {
     if (platform === 'gitlab') {