Repository navigation
fix(mobile): correct Khmer security agent remediation and deadline terms - #8470
Conversation
Use the panel's remediation noun in the unavailable, blocker and SLA copy, one deadline term across the dashboard metrics, the cancel term shared by the cancel controls, one dismiss term across the feature, a parallel manual origin label, and a depth term for the shallow analysis mode.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental change (2 Khmer catalog values) resolves both prior suggestions: the dashboard "within deadline" labels now agree on Assumptions: Files Reviewed (1 file)
Previous Review Summary (commit 1fe3015)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 1fe3015)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryCopy-only Khmer catalog change is structurally safe (JSON valid, placeholders unchanged, no duplicate values), but it leaves two user-visible terminology inconsistencies. Assumptions: Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (1 file)
Verification note: I did not execute Reviewed by deepseek-flash-latest · Input: 37.1K · Output: 2.9K · Cached: 294.9K Review guidance: REVIEW.md from base branch |
Use a noun manual-origin label that does not repeat the row label, and one deadline rendering across the dashboard posture row and the metric detail.
bot: corrects Khmer terminology in the mobile security-agent copy.
Summary
Values only in the Khmer mobile catalog; every key, placeholder and edge whitespace is unchanged.
ការជួសជុលnow renders remediation in the unavailable fallback, the analysis-required blocker and the SLA copy, replacing theកែតម្រូវ(adjust/correct) verb and the bareជួសជុល.រយៈពេលកំណត់សម្រាប់ការជួសជុល.កាលកំណត់, matching the existing no-deadline and deadline-passed labels instead ofថ្ងៃកំណត់/រយៈពេលកំណត់.បោះបង់verb as the cancel dialog and the cancelled result.ច្រានចោល, across the dismiss screen and the safe-to-dismiss analysis state, replacingមិនអើពើ.ខ្លួនឯង, using the panel manual wording without repeating the row labelដោយ.រាក់(shallow depth), contrasting with the deep labelស៊ីជម្រៅand leavingបឋមto the triage wording.Review remarks from the head review:
Verification
pnpm --filter kilo-app check:i18n: 87 languages, every catalog matches en.json; oxlint i18n config reported 0 warnings and 0 errors.node tools/i18n/check-plurals.mjs: every counted message and every locale declares its plural categories.pnpm --filter kilo-app format:check: no files differ.pnpm --filter kilo-app exec vitest run src/i18n: 16 files, 1611 tests passed.kmand asserted every changed key returned the new value withexactUsedKeyequal to the key (so the Khmer catalog answered, not the English fallback), with placeholders bound. Rendered values included:securityAgent.analysisMode.shallow-> រាក់securityAgent.dashboard.withinDeadline-> ក្នុងកាលកំណត់securityAgent.dismiss.title-> ច្រានចោលបញ្ហាដែលរកឃើញsecurityAgent.remediation.cancellationRequested-> បានស្នើសុំបោះបង់ការជួសជុលsecurityAgent.remediation.unavailable-> មិនអាចប្រើការជួសជុលសម្រាប់បញ្ហាដែលរកឃើញនេះបានទេ។securityAgent.remediationStatus.originManual-> ខ្លួនឯងsecurityAgent.sla.deadlinesHeading-> រយៈពេលកំណត់សម្រាប់ការជួសជុល (ថ្ងៃ)securityAgent.dashboardMetrics.withinDeadlineDetailwithwithin=3, total=5-> 3 ក្នុងចំណោម 5 ក្នុងកាលកំណត់Limitation: this is a copy-only catalog change and the strings live behind an authenticated security-agent surface, so the run above is the surface-level evidence; no screenshots were captured.
Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: ដោយខ្លួនឯង
Confidence: 0.80 · Precedent: Trust the code over documents: reuse the panel's existing 'manual' term, as the brief requires (session 269375d6e466, "only trust code")
Answer: Also safeToDismiss
Confidence: 0.50 · Precedent: If you see a gap or an error, fix it (session 89824a222897, "if you saw a gap, fix it"). The fix stays inside securityAgent; the shared common key is out of the brief's scope.
Answer: Align to ក្នុងកាលកំណត់
Confidence: 0.85 · Precedent: Fix the class of the issue, not the single symptom (session 00eb2a1d3e4b, "fix the class"). The brief also says to use កាលកំណត់ across dashboardMetrics.
Answer: ខ្លួនឯង
Confidence: 0.62 · Precedent: Git and pull requests: 'Run the standard PR loop: check each kilobot comment, fix it or reject it' (session 80d037e14f3a). The brief asks for a noun label that uses the panel's existing manual term. ខ្លួនឯង meets that, avoids repeating ដោយ, and keeps the manual-versus-automatic contrast.
Answer: Merge main into the branch now
Confidence: 0.90 · Precedent: Git and pull requests: merge main only when a conflict or a fix on main needs it (session a247f3c19b1e, "try merging main in, that may fix the issue")