Skip to content

fix(mobile): correct Khmer PR review terminology and merge copy - #8468

Merged
iscekic merged 2 commits into
mainfrom
drain/km-pr-review-merge-copy
Oct 22, 2026
Merged

iscekic merged 2 commits into
mainfrom
drain/km-pr-review-merge-copy

Conversation

@iscekic

@iscekic iscekic commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Twenty Khmer values on the PR-review surface drifted from the English source or from sibling keys in the same catalog. Each concept now has one term across the surfaces that render it. Keys, placeholders and the key count (3295) are unchanged; the Khmer catalog is the only file touched.

Key Before After
prReview.discussion.deletedUser អ្នកប្រើប្រាស់ដែលបានលុបគណនី អ្នកប្រើប្រាស់ដែលរកមិនឃើញ
prReview.floatingActions.commentOnSelectedLines បញ្ចេញមតិលើបន្ទាត់ដែលបានជ្រើសរើស មតិយោបល់លើបន្ទាត់ដែលបានជ្រើសរើស
prReview.merge.enableAutoMergeConfirmMessageTerm …នៅពេលបំពង់ផ្សែងជោគជ័យ។ …នៅពេលខ្សែសង្វាក់ CI ជោគជ័យ។
prReview.merge.enableAutoMergeDescriptionTerm …នៅពេលបំពង់ផ្សែងជោគជ័យ។ …នៅពេលខ្សែសង្វាក់ CI ជោគជ័យ។
prReview.merge.restrictions.pipelineMustSucceed បំពង់ផ្សែងត្រូវតែជោគជ័យមុនពេលបញ្ចូល។ ខ្សែសង្វាក់ CI ត្រូវតែជោគជ័យមុនពេលបញ្ចូល។
prReview.merge.providerBlocked.failingPipeline បំពង់ផ្សែងកំពុងបរាជ័យលើកូមីតចុងក្រោយ។ ខ្សែសង្វាក់ CI កំពុងបរាជ័យលើកូមីតចុងក្រោយ។
prReview.merge.providerBlocked.pendingPipeline បំពង់ផ្សែងកំពុងដំណើរការនៅឡើយលើកូមីតចុងក្រោយ។ ខ្សែសង្វាក់ CI កំពុងដំណើរការនៅឡើយលើកូមីតចុងក្រោយ។
prReview.mutationError.reviewNotSubmittedTerm មិនអាចដាក់សំណើការពិនិត្យនេះតាមរូបភាពបច្ចុប្បន្ន… មិនអាចដាក់ស្នើការពិនិត្យនេះក្នុងស្ថានភាពបច្ចុប្បន្ន… (same verb and "as is" phrase as reviewNotSubmitted)
prReview.overview.reviewChangesRequested បានស្នើឱ្យកែប្រែ បានស្នើសុំការកែប្រែ
prReview.review ការពិនិត្យ ពិនិត្យ
prReview.submit.deletePendingTitle លុបមតិយោបល់មិនទាន់ផ្ញើ? លុបមតិយោបល់មិនទាន់ដាក់ស្នើ?
prReview.submit.pendingComment_one មតិយោបល់មិនទាន់ផ្ញើ មតិយោបល់មិនទាន់ដាក់ស្នើ
prReview.pendingComment.editOutdatedA11y …មតិយោបល់មិនទាន់ផ្ញើ… …មតិយោបល់មិនទាន់ដាក់ស្នើ…
prReview.pendingComment.editA11y …មតិយោបល់មិនទាន់ផ្ញើ… …មតិយោបល់មិនទាន់ដាក់ស្នើ…
prReview.pendingComment.deleteA11y …មតិយោបល់មិនទាន់ផ្ញើ… …មតិយោបល់មិនទាន់ដាក់ស្នើ…
prReview.pendingComment.deletedAnnouncement បានលុបមតិយោបល់មិនទាន់ផ្ញើ បានលុបមតិយោបល់មិនទាន់ដាក់ស្នើ
prReview.pendingComment.staleQueueHint …នឹងមិនត្រូវផ្ញើទេ។ …នឹងមិនត្រូវបានដាក់ស្នើទេ។
prReview.pendingComment.staleHint pR បានផ្លាស់ប្តូរ… PR បានផ្លាស់ប្តូរ…
prReview.terms.mergeRequestNumber !{{number}} សំណើបញ្ចូល !{{number}}
prReview.terms.discussionAccessDenied …របស់ សំណើបញ្ចូល នេះទេ។ …របស់សំណើបញ្ចូលនេះទេ។

Notes on the change:

  • The CI pipeline read as the word for a chimney (បំពង់ផ្សែង). All five merge keys that name it now use ខ្សែសង្វាក់ CI, and the two auto-merge messages keep their {{term}}, GitHub and GitLab wording.
  • The comment-author fallback labels both deleted and banned authors, so it no longer asserts that the account was deleted.
  • prReview.review is the visible text of the review button and the label above it, and no separate heading key exists, so it is the verb.
  • prReview.floatingActions.comment is មតិយោបល់ on main (the shared composer/chip term), so after this change the floating action's visible label and its accessibility label read with the same term. The accessibility label is the only key this change touches in that group; the composer and review-event chip keys come from main.
  • The catalog check holds one wording per English string and one script per catalog; every changed key is its own wording group, and Latin PR, CI and GitLab ride along as the rest of the catalog already does.

Verification

Run on the work VM against this branch.

  • pnpm --filter kilo-app check:i18n — Found 0 warnings and 0 errors, check-catalogs: 87 languages, every catalog matches en.json.
  • node tools/i18n/check-plurals.mjs — every counted message and every locale declares its plural categories.
  • pnpm exec oxfmt --check apps/mobile/src/i18n/locales/km.json — clean.
  • pnpm --filter kilo-app exec vitest run src/components/pr-review src/i18n — 78 files, 2212 tests passed.
  • Throwaway render smoke (deleted before the commit), re-run after main was merged into the branch: switched the app's own i18next instance to Khmer and drove real consumers. Rendered output:
selectCommentAuthorName(null) = អ្នកប្រើប្រាស់ដែលរកមិនឃើញ
state chip = បើក · បានស្នើសុំការកែប្រែ | reviewer verdict = បានស្នើសុំការកែប្រែ
pending row text = src/a.ts:L1 | note | ហួសសម័យ | PR បានផ្លាស់ប្តូរបន្ទាប់ពីអ្នកសរសេរមតិយោបល់នេះ។
pending row a11y = កែសម្រួលមតិយោបល់មិនទាន់ដាក់ស្នើដែលលែងទាន់សម័យនៅ src/a.ts:L1 | លុបមតិយោបល់មិនទាន់ដាក់ស្នើនៅ src/a.ts:L1
floating bar = ["src/a.ts RIGHT L1–L3","a11y:ដកការជ្រើសរើសចេញ","ដកចេញ","a11y:មតិយោបល់លើបន្ទាត់ដែលបានជ្រើសរើស","មតិយោបល់","a11y:បញ្ចប់ការពិនិត្យ","បញ្ចប់ការពិនិត្យ"]
submit rejection = មិនអាចដាក់ស្នើការពិនិត្យនេះក្នុងស្ថានភាពបច្ចុប្បន្នបានទេ។ សំណើបញ្ចូល អាចបានផ្លាស់ប្តូរ ឬអ្នកកំពុងពិនិត្យសំណើបញ្ចូលរបស់ខ្លួនឯង ដែលមិនត្រូវបានអនុញ្ញាត។
{
 "review": "ពិនិត្យ",
 "autoMergeConfirm": "សំណើបញ្ចូល នឹងត្រូវបានបញ្ចូលដោយស្វ័យប្រវត្តិនៅពេលខ្សែសង្វាក់ CI ជោគជ័យ។",
 "autoMergeDescription": "GitLab នឹងបញ្ចូលសំណើបញ្ចូលនេះដោយស្វ័យប្រវត្តិនៅពេលខ្សែសង្វាក់ CI ជោគជ័យ។",
 "failingPipeline": "ខ្សែសង្វាក់ CI កំពុងបរាជ័យលើកូមីតចុងក្រោយ។",
 "pendingPipeline": "ខ្សែសង្វាក់ CI កំពុងដំណើរការនៅឡើយលើកូមីតចុងក្រោយ។",
 "pipelineMustSucceed": "ខ្សែសង្វាក់ CI ត្រូវតែជោគជ័យមុនពេលបញ្ចូល។",
 "mergeRequestNumber": "សំណើបញ្ចូល !42",
 "discussionAccessDenied": "អ្នកគ្មានសិទ្ធិមើលការពិភាក្សារបស់សំណើបញ្ចូលនេះទេ។"
}

No screenshot is attached: this is a values-only catalog change, and every changed string sits behind a connected provider and a real pull request on the device. The render smoke above is the observed behavior.

Proxy answers

The owner's proxy gave these answers in the owner's place.

  1. Question: CI pipeline noun: Five merge keys name the CI pipeline today as បំពង់ផ្សែង (chimney). No Khmer CI term exists anywhere in the km catalog to copy. Which noun should all five use?
    Answer: ខ្សែសង្វាក់ CI
    Confidence: 0.60 · Precedent: none
  2. Question: Unavailable author: The comment-author fallback covers deleted and banned accounts (author: null). Which neutral Khmer label replaces អ្នកប្រើប្រាស់ដែលបានលុបគណនី ("user who deleted the account")?
    Answer: អ្នកប្រើប្រាស់ដែលរកមិនឃើញ
    Confidence: 0.55 · Precedent: none
  3. Question: Changes requested: The chip (បើក · បានស្នើសុំការកែប្រែ) and the reviewer verdict (បានស្នើឱ្យកែប្រែ) render English "Changes requested" two ways. Which phrase wins?
    Answer: បានស្នើសុំការកែប្រែ
    Confidence: 0.65 · Precedent: Keep similar elements consistent across surfaces: session a247f3c19b1e, "the thought row match the tool call row"; least work: session 7f3470e0ba6f, "do the least amount of work possible, with no drop in quality"
  4. Question: Pending-comment family: The brief names deletePendingTitle and submit.pendingComment(_one/_other) for the "not yet submitted" term. Five more keys in the same submit sheet still say មិនទាន់ផ្ញើ ("not yet sent"): pendingComment.editA11y, editOutdatedA11y, deleteA11y, deletedAnnouncement, staleQueueHint. Extend?
    Answer: Align all seven keys
    Confidence: 0.60 · Precedent: Fix the root cause and the class of the issue: session 00eb2a1d3e4b, "if anything repeats the same mistake over and over again, fix the class"; session 89824a222897, "if you saw a gap, fix it"

Khmer values on the PR-review surface drifted from the English source or
from sibling keys. Values now use one term per concept: the CI pipeline is
named with a software term instead of the word for a chimney, the diff
floating action's accessibility label uses the comment term the rest of
the comment surfaces use, review submission reuses its sibling key's verb
and "as is" phrase, changes requested reads one way in the state chip and
the reviewer verdict, queued comments use one not-yet-submitted term
across the submit sheet, the PR acronym has one casing, the merge-request
noun precedes the GitLab reference in the screen title, and the
access-denied sentence carries no stray spaces. The comment-author
fallback no longer states that the account was deleted, because the same
label covers banned authors.

Keys, placeholders and the key count are unchanged; the Khmer catalog is
the only file touched.
@iscekic iscekic added drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks labels Oct 21, 2026
@kilo-code-bot

kilo-code-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the 20 Khmer catalog value changes in apps/mobile/src/i18n/locales/km.json; every changed key keeps its English placeholder set and key shape, the new terms match the sibling consumers I read (prReview.terms.mergeRequestNumber is only the GitLab screen title and aligns with English Merge request !{{number}}, staleHint/reviewNotSubmittedTerm match their unchanged siblings), and no other catalog entry still carries the old chimney, lowercase pR, or មិនទាន់ផ្ញើ wordings.

Assumptions: [INFERENCE] Khmer linguistic correctness of the new terms is not independently verifiable from the repository; it was taken from the PR's render smoke and proxy answers. The floating action's visible label prReview.floatingActions.comment still uses អត្ថាធិប្បាយ while its changed accessibility label now uses មតិយោបល់; the PR states a companion change aligns those keys, so this is a sequencing dependency rather than a defect in this diff.

Files Reviewed (1 file)
  • apps/mobile/src/i18n/locales/km.json

Reviewed by deepseek-flash-latest · Input: 63.7K · Output: 11.7K · Cached: 1M

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the merge:bot Bot-owned review; merge when ready once readiness passes and a review approves. label Oct 21, 2026
…rge-copy

# Conflicts:
#	apps/mobile/src/i18n/locales/km.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks merge:bot Bot-owned review; merge when ready once readiness passes and a review approves.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants