Repository navigation
fix(mobile): correct Khmer PR review terminology and merge copy - #8468
Conversation
Khmer values on the PR-review surface drifted from the English source or from sibling keys. Values now use one term per concept: the CI pipeline is named with a software term instead of the word for a chimney, the diff floating action's accessibility label uses the comment term the rest of the comment surfaces use, review submission reuses its sibling key's verb and "as is" phrase, changes requested reads one way in the state chip and the reviewer verdict, queued comments use one not-yet-submitted term across the submit sheet, the PR acronym has one casing, the merge-request noun precedes the GitLab reference in the screen title, and the access-denied sentence carries no stray spaces. The comment-author fallback no longer states that the account was deleted, because the same label covers banned authors. Keys, placeholders and the key count are unchanged; the Khmer catalog is the only file touched.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the 20 Khmer catalog value changes in Assumptions: Files Reviewed (1 file)
Reviewed by deepseek-flash-latest · Input: 63.7K · Output: 11.7K · Cached: 1M Review guidance: REVIEW.md from base branch |
…rge-copy # Conflicts: # apps/mobile/src/i18n/locales/km.json
Summary
Twenty Khmer values on the PR-review surface drifted from the English source or from sibling keys in the same catalog. Each concept now has one term across the surfaces that render it. Keys, placeholders and the key count (3295) are unchanged; the Khmer catalog is the only file touched.
prReview.discussion.deletedUserprReview.floatingActions.commentOnSelectedLinesprReview.merge.enableAutoMergeConfirmMessageTermprReview.merge.enableAutoMergeDescriptionTermprReview.merge.restrictions.pipelineMustSucceedprReview.merge.providerBlocked.failingPipelineprReview.merge.providerBlocked.pendingPipelineprReview.mutationError.reviewNotSubmittedTermreviewNotSubmitted)prReview.overview.reviewChangesRequestedprReview.reviewprReview.submit.deletePendingTitleprReview.submit.pendingComment_oneprReview.pendingComment.editOutdatedA11yprReview.pendingComment.editA11yprReview.pendingComment.deleteA11yprReview.pendingComment.deletedAnnouncementprReview.pendingComment.staleQueueHintprReview.pendingComment.staleHintprReview.terms.mergeRequestNumberprReview.terms.discussionAccessDeniedNotes on the change:
{{term}}, GitHub and GitLab wording.prReview.reviewis the visible text of the review button and the label above it, and no separate heading key exists, so it is the verb.prReview.floatingActions.commentis មតិយោបល់ onmain(the shared composer/chip term), so after this change the floating action's visible label and its accessibility label read with the same term. The accessibility label is the only key this change touches in that group; the composer and review-event chip keys come frommain.PR,CIandGitLabride along as the rest of the catalog already does.Verification
Run on the work VM against this branch.
pnpm --filter kilo-app check:i18n—Found 0 warnings and 0 errors,check-catalogs: 87 languages, every catalog matches en.json.node tools/i18n/check-plurals.mjs—every counted message and every locale declares its plural categories.pnpm exec oxfmt --check apps/mobile/src/i18n/locales/km.json— clean.pnpm --filter kilo-app exec vitest run src/components/pr-review src/i18n— 78 files, 2212 tests passed.mainwas merged into the branch: switched the app's own i18next instance to Khmer and drove real consumers. Rendered output:No screenshot is attached: this is a values-only catalog change, and every changed string sits behind a connected provider and a real pull request on the device. The render smoke above is the observed behavior.
Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: ខ្សែសង្វាក់ CI
Confidence: 0.60 · Precedent: none
Answer: អ្នកប្រើប្រាស់ដែលរកមិនឃើញ
Confidence: 0.55 · Precedent: none
Answer: បានស្នើសុំការកែប្រែ
Confidence: 0.65 · Precedent: Keep similar elements consistent across surfaces: session a247f3c19b1e, "the thought row match the tool call row"; least work: session 7f3470e0ba6f, "do the least amount of work possible, with no drop in quality"
Answer: Align all seven keys
Confidence: 0.60 · Precedent: Fix the root cause and the class of the issue: session 00eb2a1d3e4b, "if anything repeats the same mistake over and over again, fix the class"; session 89824a222897, "if you saw a gap, fix it"