Repository navigation
fix(mobile): correct Khmer consent, sign-in, Kilo Pass, credits and notification copy - #8464
Conversation
…otification copy Retranslate the reviewed Khmer values that narrowed or misstated the English source: - consent: one wording for AI prompts across the gateway data list and the install-attribution alert, the alert keeps the unconditional "never used" promise, and "install attribution" no longer reuses the Settings noun. - credits: the price fallback and the empty-catalog line say the price or the packs are not available, instead of that they cannot be used. - device sessions: the sign-out confirmation credits the remaining API access to the revoked device, not the phone in the user's hand. - Kilo Pass: the error heading says the page could not load, and the two storefront labels share one "products unavailable" phrase with no download verb. - login: a failed passkey now points at Apple, Google or email, like its sibling messages. - notifications: the security channel uses the same "findings" term as the security category, and both preview retry labels use the preview wording of the show-full-previews label. - organization Kilo Pass: one seat term across the paid-seat row and the overallocated warning.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the 17 Khmer value corrections in Assumptions: Files Reviewed (1 file)
Reviewed by deepseek-flash-latest · Input: 132.7K · Output: 15K · Cached: 1.3M Review guidance: REVIEW.md from base branch |
Summary
Retranslates 17 reviewed Khmer values in the mobile Khmer catalog so they match their English sources. Values only: no key is added or removed, and every interpolation is preserved.
gatewayWhat… ព្រមទាំងសេចក្តីណែនាំ និងការថតសំឡេង…installAttributionPromptMessage… យើងមិនដែលប្រើសេចក្តីណែនាំ និងការសន្ទនារបស់អ្នកទេ។installAttributionTitleការស្គាល់ប្រភពដំឡើងinstallAttributionPromptTitleអនុញ្ញាតឱ្យស្គាល់ប្រភពដំឡើង?priceUnavailableតម្លៃមិនមានទេemptyកញ្ចប់ឥណទានមិនមាននៅពេលនេះទេ។signOutThisSessionMessage{{device}} នឹងត្រូវបានចេញពីគណនី។ ឧបករណ៍នោះនៅតែអាចចូលប្រើ API បានរហូតដល់មួយម៉ោងទៀត។unavailableផ្ទុក Kilo Pass មិនបានទេ។productsUnavailableផលិតផល App Store មិនមានទេproductsUnavailablePlayផលិតផល Google Play មិនមានទេpasskeyFailedមិនអាចចូលដោយកូនសោចូលបានទេ។ សូមចូលដោយ Apple, Google ឬអ៊ីមែលរបស់អ្នកជំនួសវិញ។channel.securityការរកឃើញសុវត្ថិភាពretryPreviewsព្យាយាមផ្ទុកសារជាមុននៃការជូនដំណឹងម្តងទៀតretrySavingPreviewsព្យាយាមរក្សាទុកសារជាមុននៃការជូនដំណឹងម្តងទៀតpaidSeat,paidSeat_other,paidSeat_oneកន្លែងសមាជិកដែលបានបង់ប្រាក់ {{displayCount}}What each change fixes:
English copy is unchanged, so no other catalog moves.
paidSeat_onestays in the catalog as the brief requires; Khmer resolves the plural "other" category for every count.Verification
Run on the work VM against this branch:
pnpm --filter kilo-app check:i18n→check-catalogs: 87 languages, every catalog matches en.json; oxlint 0 warnings, 0 errors.node tools/i18n/check-plurals.mjs→check-plurals: every counted message and every locale declares its plural categories.pnpm --filter kilo-app format:check→ no files listed.pnpm --filter kilo-app exec vitest run src/i18n→ 17 files, 1616 tests passed (catalog parity, one-wording, plural families, label reference, unavailable-category reasons).pnpm --filter kilo-app exec vitest run src/components/kilo-pass src/components/organization src/lib/kilo-pass src/components/credits src/components/device-sessions→ 23 files, 216 tests passed.pnpm --filter kilo-app exec vitest run src/components/notifications-screen.mounted.test.tsx→ 33 tests passed with the catalog's own channel label.A throwaway render test (deleted before the commit) switched i18n to Khmer, asserted
exactUsedKeyfor all 17 keys, and printed what the real consumers show. Observed output:The profile card error title, the organization row subtitle, the sign-out confirmation, the passkey toast and the credit row accessibility label above come from the real consumers, not from the raw catalog.
No screenshots: this is catalog text behind authenticated, provider-connected screens and no layout moves. The one-wording check passes, so no wording exception was needed and the exceptions file is untouched.
Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: ការស្គាល់ប្រភពដំឡើង (recognizing the install source)
Confidence: 0.75 · Precedent: Keep similar elements consistent across surfaces: an earlier session, "thought row match the tool call row". This option drops ការកំណត់ as the brief directs and avoids clashing with Apple's tracking wording.
Answer: ផ្ទុក Kilo Pass មិនបានទេ។
Confidence: 0.70 · Precedent: Remove redundant copy: an earlier session, owner asked to remove the redundant "context" copy. The other option would show the same sentence twice on one screen.
Answer: Native សេចក្តីណែនាំ in both keys
Confidence: 0.80 · Precedent: Keep similar elements consistent across surfaces: an earlier session. Four other consent keys already use សេចក្តីណែនាំ.