Repository navigation
fix(mobile): correct Khmer code reviewer, status and PR discussion copy - #8462
Merged
Merged
Conversation
The Khmer catalog now names the manual-review flow by hand rather than on request, uses one review-memory term across the feature, derives the cancelled status from the Cancel verb, drops the sentence mark from the not-found label, uses one comment term across the PR composers, and labels the thread control with the collapse verb its check state implies.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the ten Khmer copy changes in Assumptions: Files Reviewed (1 file)
Reviewed by deepseek-flash-latest · Input: 66.9K · Output: 10.1K · Cached: 991.6K Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Oct 21, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eight Khmer values were out of step with the English source or with each other. All are visible copy in the app; keys, placeholders and file structure are unchanged (3290 keys before and after).
codeReviewer.manualReview.titleandcodeReviewer.reviewList.startManualReviewsaid the review happens on request (តាមការស្នើសុំ), which reads as "when someone asks", not as the review the user starts themselves. Both now use the catalog's manual term (ដោយដៃ), so the review-list call-to-action, the manual-review screen header and the profile row that opens it read one way.codeReviewer.reviewMemory.titlenamed the featureការចងចាំពីការពិនិត្យwhile its own loading, off, read-only and enable strings sayអង្គចងចាំសម្រាប់ការត្រួតពិនិត្យ, with a different word for "review" as well. The title now matches the family.common.cancelledwasបានលុបចោល(from the verb for abolishing/removing), while the Cancel action isបោះបង់. The status now readsបានបោះបង់, the same root the remediation status already uses, so the review-list chip and the finding remediation panel no longer say an operation was removed.common.notFoundended in the Khmer sentence terminator while it renders as an error heading (chat header, terminal-session error), and the sibling short labels carry none. The trailing។is gone.prReview.composer.commentsaidអត្ថាធិប្បាយ(commentary) as the section label over the body field, whose accessibility label and placeholder already sayមតិយោបល់. The catalog check holds one wording per English string, so the same move covers the diff floating action and the review-event chip, andprReview.composer.commentNowcarries the term on its submit button.prReview.discussion.collapseThreadis the accessibility label of the expanded thread header, which collapses it. It saidលាក់ការពិភាក្សា("hide the discussion"); it now saysបង្រួមការពិភាក្សា, the verb the catalog already uses for collapsing.common.cancelledcommon.notFoundcodeReviewer.reviewMemory.titlecodeReviewer.manualReview.titlecodeReviewer.reviewList.startManualReviewprReview.composer.commentprReview.floatingActions.commentprReview.eventChips.commentprReview.composer.commentNowprReview.discussion.collapseThreadCopy lives in the English catalog; a reviewed translation slice edits one catalog by hand and the parity checks guard it. This change touches the Khmer catalog only.
Verification
Run on the work VM against this branch.
pnpm --filter kilo-app check:i18n—Found 0 warnings and 0 errors,check-catalogs: 87 languages, every catalog matches en.json.node tools/i18n/check-plurals.mjs— every counted message and every locale declares its plural categories.pnpm --filter kilo-app format:check— clean.pnpm --filter kilo-app exec vitest run src/i18n— 17 files, 1612 tests passed, with a throwaway render smoke in place.pnpm --filter kilo-app exec vitest run src/components/code-reviewer src/components/pr-review— 68 files, 754 tests passed.The one-wording check groups English
Commentacross the composer label, the diff floating action and the review-event chip; all three move together, so no wording-exception entry is needed. Every other changed key is its own wording group.Render smoke (throwaway test, deleted before the commit) switched the app's own i18next instance to Khmer with
fallbackLng: 'en', assertedexactUsedKeyso an English fallback fails the run, and drove a real consumer. Rendered output:The not-found value is asserted through the terminal-session error copy builder, a real caller that renders the label as an error heading. No screenshot is attached: every changed string sits behind an authenticated Code Reviewer or PR screen with a connected provider, and this is a values-only catalog change with no visual layout to capture.
Proxy answers
The owner's proxy gave these answers in the owner's place.
startManualReviewto use "the same manual-review term ascodeReviewer.manualReview.title". Evidence: that title also reads "on request" (ការត្រួតពិនិត្យតាមការស្នើសុំ), so aligning the CTA to it would keep the defect. The brief also says edit only keys the findings name; the title is not named. Which scope?Answer: Fix title + CTA to "by hand"
Confidence: 0.72 · Precedent: Fix the root cause and the class of the issue: "fix class of issue preventing progress"; If you see a gap, fix it: "if you saw a gap, fix it"
prReview.composer.commentNowis the primary button in the comment sheet (English "Comment now"). It currently uses បញ្ចេញមតិឥឡូវនេះ. Which imperative form should carry the new មតិយោបល់ term?Answer: ផ្ញើមតិយោបល់ឥឡូវនេះ
Confidence: 0.60 · Precedent: Make every surface pleasant to look at and remove redundant copy: owner asked to remove the redundant "context" copy
composer.comment,floatingActions.comment(diff floating action) andeventChips.comment(review-event chip) — all currently អត្ថាធិប្បាយ, and Khmer has no wording exception for it. How should the composer term change?Answer: Move all three to មតិយោបល់
Confidence: 0.70 · Precedent: Keep similar elements consistent across surfaces: owner asked that "the thought row match the tool call row"; Keep each PR diff to files that the feature needs
prReview.discussion.collapseThread(a11y label on the expanded thread header, English "Collapse thread") reads លាក់ការពិភាក្សា ("hide the discussion"). Which Khmer wording?Answer: បង្រួមការពិភាក្សា
Confidence: 0.70 · Precedent: Keep similar elements consistent across surfaces: owner asked that "the thought row match the tool call row"