Repository navigation
fix(mobile): correct Hungarian apply, email channel and GGUF prompt copy - #8409
Merged
Merged
Conversation
The Hungarian catalog rendered the shared filter action as the noun for an application, the delivery-channel label as an email address, and two terms for prompts in the on-device model copy. - common.apply is the imperative "Alkalmaz", rendered by the session filter sheet and the security finding filter sheet. - common.email is the channel and field label "E-mail", matching the English "Email" that every call site names. - modelChat.gguf.help, modelChat.gguf.localPurpose and modelChat.localModels.help describe prompts with the formal "utasítás" forms used by the model-chat backend copy.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the five Hungarian catalog value edits in Files Reviewed (1 file)
Reviewed by deepseek-v4.1-flash-1017 · Input: 42.7K · Output: 6.6K · Cached: 409.6K Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
bot: Captures from the Android emulator running the local dev stack with the app language set to Hungarian and an owned fake account.
|
eshurakov
approved these changes
Oct 21, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Hungarian catalog rendered the shared filter action as the noun for an application, named the email delivery channel as an email address, and used two different words for prompts in the on-device model copy. This changes five values in the Hungarian catalog; keys, placeholders, plural families and every other catalog are unchanged.
common.apply(rendered by the session filter sheet and by the security finding filter sheet) is the imperative Alkalmaz.common.emailis the channel and field label E-mail. Every call site names the shared English "Email" (the provider label, the invite member field above itsnev@ceg.huplaceholder, the spend-alert channel row and its composed switch label), so the channel reads as a channel and the address-specific wording stays in its own login key.modelChat.gguf.help,modelChat.gguf.localPurposeandmodelChat.localModels.helpdescribe prompts with the formal utasítás forms already used by the model-chat backend copy, so the on-device model section uses one term with matching possessive and plural forms.The catalog is edited as a reviewed translation slice; the parity checks are the guard.
Verification
Flattened comparison against the base branch: 5 changed values, 0 keys added, 0 removed.
Runtime resolution through the app's own i18next options (Hungarian selected, English fallback configured) returned the new values for all five keys, with the exact key reported by
returnDetails:Android emulator, app language set to Hungarian, owned fake account on the local dev stack, screens each read from the accessibility tree and OCR of the captured frame:
MégseandAlkalmaz; the action commits the selected filters.E-mail, and the switch beside it carries the composed labelKüszöbátlépés és E-mail.utasításwording in one screen.Screenshots are attached in a follow-up comment.
Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: "utasítás" across the sheet
Confidence: 0.55 · Precedent: Keep similar elements consistent and fix the class: the owner asked that "the thought row match the tool call row" and to "fix the class". Using "utasítás" matches the rest of the model-chat backends copy, and localModels.help is in the Hungarian catalog, so it stays within scope.
Answer: Keep the gguf block formal
Confidence: 0.50 · Precedent: Trust the code over documents: "only trust code". The active modelChat item leaves the gguf block formal, so changing only two keys would mix registers in one block. Keep every new possessive formal (-ai), including the localModels.help edit.
Answer: "E-mail" everywhere (brief's option)
Confidence: 0.75 · Precedent: Do the least work with no drop in quality: "do the least amount of work possible, with no drop in quality". It matches the English source, which shows "Email" above the same placeholder, and needs no new keys.
Answer: "Alkalmaz" (finding + brief)
Confidence: 0.85 · Precedent: Do the least work with no drop in quality: "skip work that doesn't need to be done". One value covers both call sites, it follows the Hungarian platform convention, and it is what the brief asks for.