Skip to content

fix(mobile): use one Hausa term for voice input in the test field title - #8392

Merged
iscekic merged 1 commit into
mainfrom
drain/ha-voice-input-test-title
Oct 21, 2026
Merged

iscekic merged 1 commit into
mainfrom
drain/ha-voice-input-test-title

Conversation

@iscekic

@iscekic iscekic commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

The Hausa test field title now names voice input with the same phrase as the Hausa voice-input messages rendered by the same field.

  • One catalog value changed: the Hausa voiceInput.testTitle entry.
  • No keys added or removed, no placeholders touched, no other catalog touched, no English copy touched.
  • English Test voice input is its own English string, so the catalog consistency check keeps preferences.voiceInput on the short row label.

Verification

Static checks on the work VM, on the branch head:

  • Catalog consistency check: 87 languages, every catalog matches English, 0 lint findings.
  • Plural check: every counted message and locale declares its plural categories.
  • Format check and mobile typecheck: clean.
  • Path diff against main: exactly one changed value, 0 added keys, 0 removed keys.

Runtime:

  • Throwaway mounted render smoke in Hausa: voiceInput.testTitle resolved from the Hausa catalog (exactUsedKey matched, so no English fallback), and the real voice test field rendered the new heading. Removed before committing.
  • Android emulator end to end on this work VM: local dev stack, CI dev client, owned fake account signed in through the app's own email-code flow, app language set to Hausa. The voice input settings screen renders the new heading Gwada shigar da rubutu ta murya, next to the microphone control Fara shigar da rubutu ta murya.
  • Screenshot of that screen is attached in the comment below.

Proxy answers

The owner's proxy gave these answers in the owner's place.

  1. Question: Verification: This is a one-line Hausa catalog string (voiceInput.testTitle). How deep should end-to-end verification go on this VM?
    Answer: Boot mobile dev stack + Android emulator in Hausa, screenshot the voice test field
    Confidence: 0.72 · Precedent: Proof and verification: 'logs and/or screenshots are mandatory proof ... make sure they make sense'; Android on the work VM by default
  2. Question: Scope: voiceLanguage.title in ha.json ("Harshen shigar da murya") also uses the short form, but it is a different key (voice language, not voice input).
    Answer: Change only voiceInput.testTitle
    Confidence: 0.65 · Precedent: Git and pull requests: put each separate concern in its own PR, 'in a separate PR'; keep the PR diff to files and changes the item needs
  3. Question: Hausa heading: Hausa wording: the voice test field renders under the Preferences row whose English "Voice input" is the short "Shigar da murya" (preferences.voiceInput, catalog line 264), while every voiceInput.* message uses the long "shigar da rubutu ta murya". The heading "Test voice input" (voiceInput.testTitle) currently uses the short form. The finding and brief say to change the heading to the long form; that evidence about the row label was not in the finding. Which way?
    Answer: Apply long form
    Confidence: 0.75 · Precedent: Keep each PR diff to files that the feature needs ("PR should be checked for stray changes before merging"). The brief says to change only testTitle, and the row label has a different English source, so the check permits it to stay short.

The Hausa test field title described voice input with a shorter phrase than
the Hausa voice-input messages that the same field renders. Use the long form
in the test field title too, so the heading and the control messages name the
feature the same way.
@iscekic iscekic added drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks labels Oct 21, 2026
@iscekic

iscekic commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

bot: Hausa voice input settings screen on the Android emulator from this branch. The test field heading reads Gwada shigar da rubutu ta murya, matching the microphone control Fara shigar da rubutu ta murya; the placeholder Danna makirufo ka fara magana. and the Share rubutu action are unchanged. Captured against the local dev stack with the CI dev client, an owned fake account, and the app language set to Hausa.

Hausa voice input settings screen showing the test field heading

@kilo-code-bot

kilo-code-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Single-value Hausa catalog wording change in voiceInput.testTitle; the new phrase matches the long-form term already used across the voiceInput.* messages, keys and placeholders are untouched, and no code or logic changes are involved.

Files Reviewed (1 file)
  • apps/mobile/src/i18n/locales/ha.json

Reviewed by deepseek-v4.1-flash-1017 · Input: 27.5K · Output: 2.2K · Cached: 249.3K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the merge:bot Bot-owned review; merge when ready once readiness passes and a review approves. label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks merge:bot Bot-owned review; merge when ready once readiness passes and a review approves.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants