Repository navigation
fix(mobile): correct remaining Swedish common and consent copy - #8390
Merged
Merged
Conversation
Render the dismissed status with the Swedish dismiss stem, drop the terminal period from the image-unavailable label, and keep the default-off negation in the crash-reporting note.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe three Swedish value corrections are accurate and low risk; the only concern is that Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Reviewed by deepseek-v4.1-flash-1017 · Input: 35.2K · Output: 6K · Cached: 422.8K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Oct 21, 2026
Resolve apps/mobile/src/i18n/locales/sv.json by keeping the Swedish dismissed, image-unavailable and crash-reporting strings from this branch and taking main's common.agent value.
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three value corrections in the mobile app's Swedish catalog (
apps/mobile/src/i18n/locales/sv.json). Keys, placeholders and the English source are unchanged; no other locale is touched.common.dismissedAvskrivenAvfärdadcommon.imageUnavailableBilden är inte tillgänglig.Bilden är inte tillgängligconsent.crashReportingNoteKraschrapporter innehåller bara skärmbilder om du har aktiverat den valfria delningen (se nedan). Vi registrerar aldrig skärmens vyhierarki.Kraschrapporter innehåller inga skärmbilder om du inte har aktiverat den valfria delningen (se nedan). Vi registrerar aldrig skärmens vyhierarki.Reasons:
common.dismissedis the status label for a dismissed security finding (finding-details-panel.tsx:112,finding-filter-modal.tsx:46), a dismissed briefing item (briefing-list-screen.tsx:210) and the closed-with-dismissal deadline label (security-agent-copy.ts:157).Avskrivenmeans written off or decommissioned.Avfärdaduses the dismiss stem the same catalog already renders for dismissing a suggestion (Förslag avfärdat,Det gick inte att avfärda det här förslaget.) and composes correctly insecurityAgent.deadline.closedOn({{status}} {{date}}).common.imageUnavailableis an inline chip beside an alert icon (file-part-renderer.tsx,tool-card-image-attachments.tsx,image-viewer.tsx,message-attachment.tsx) and is concatenated directly before alt text with a newline (markdown-image.tsx:222). English has no terminal period; dropping it matches the label form and the concatenation now readsBilden är inte tillgängligfollowed by the alt line.consent.crashReportingNotenow states that crash reports contain no screenshots unless optional sharing is enabled, matching the English default-off claim. The second sentence, the(se nedan)reference and the establishedskärmbilderterm (errorScreenshotsTitle) are kept.The dismissed status label is inside a single-member English wording group, so no entry in the wording exceptions file is needed.
securityAgent.findingDetails.dismissedBecauseis a separate key owned by another open Swedish copy PR and is untouched here.Verification
On a clean work VM at
861ea58af7b9:pnpm --filter kilo-app check:i18n— oxlint i18n config clean,check-catalogs: 87 languages, every catalog matches en.json.pnpm --filter kilo-app run check:plurals— every counted message declares its plural categories.pnpm --filter kilo-app format:check— no files differ.pnpm --filter kilo-app exec vitest run src/i18n— 17 files, 1610 tests passed (includes a throwaway runtime smoke, deleted before the commit).origin/main— 3285 keys before and after, no added or removed key, exactly the three values above changed.changeLanguage('sv'),returnDetails: true) assertedexactUsedKeyequals each key (no English fallback) and printed the rendered copy:No screenshot: these are string values behind an authenticated security-agent screen and a consent screen, with no layout change.
Merge resolution:
mainadvanced while this branch was open, so commitb439985emergesmaininto the branch. The only conflict wasapps/mobile/src/i18n/locales/sv.json:mainrenamed the adjacentcommon.agentvalue, and Git grouped that with this branch'scommon.dismissededit into one hunk. The resolution keeps this branch's three values above and main'scommon.agent; the diff againstorigin/mainis still exactly the three values in the table.Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: Avfärdad
Confidence: 0.90 · Precedent: Keep similar elements consistent across surfaces: session 1, "thought row match the tool call row". The brief also names "Avfärdad", which matches the existing "avfärda" stem.
Answer: Leave it to the sibling PR
Confidence: 0.80 · Precedent: Put each separate concern in its own PR: session 2, "in a separate PR". Never redo completed work: session 3, "do not redo work that was already done". The sibling PR already fixes this key.