Skip to content

ca_fecb3fb25246: recognize bounded nested timeout envelopes - #8360

Merged
eshurakov merged 1 commit into
mainfrom
eshurakov/cafecb3f-timeout-shape-20261020
Oct 21, 2026
Merged

eshurakov merged 1 commit into
mainfrom
eshurakov/cafecb3f-timeout-shape-20261020

Conversation

@eshurakov

@eshurakov eshurakov commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Why this PR is needed

A nested Responses API 504 timeout falls through to an unknown assistant error, hiding the useful timeout explanation. This PR recognizes that envelope and uses the existing timeout classification and safe message; it does not change deadlines or retries.

Summary

  • Correct ca_fecb3fb25246 in the existing bounded assistant-failure parser.
  • Recognize the known nested Responses timeout envelope and reuse numeric HTTP 504 classification and canonical safe copy.
  • Preserve direct-status authority, recognized origins, ownership, malformed-field tolerance, and the response-body size bound.

Verification

  • The real regression failed before the correction.
  • Independent safe-projection and ingest suites passed, including compaction, ownership, privacy, and precedence controls.
  • Focused adjacent tests, service/wrapper typecheck, scoped lint/format, and git diff --check passed.

This changes classification and explanation only. It does not change provider deadlines, retries, routing, or the separate 499 correction. Live production and end-to-end checks were not run.

@eshurakov
eshurakov marked this pull request as ready for review October 21, 2026 09:11
@kilo-code-bot

kilo-code-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The nested timeout envelope is parsed with the same independently-tolerant, size-bounded field handling as the existing body fields, is gated behind the existing origin/status/name precedence, and returns the canonical timeout classification; the added tests cover the malformed, oversized, ownership, and compaction paths.

Files Reviewed (3 files)
  • services/cloud-agent-next/src/shared/assistant-failure.ts
  • services/cloud-agent-next/src/session/safe-failure-projection.test.ts
  • services/cloud-agent-next/src/websocket/ingest.test.ts

Reviewed by deepseek-v4.1-flash-1017 · Input: 60.9K · Output: 17.2K · Cached: 1M

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants