Repository navigation
ca_fecb3fb25246: recognize bounded nested timeout envelopes - #8360
Merged
Merged
Conversation
eshurakov
marked this pull request as ready for review
October 21, 2026 09:11
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe nested timeout envelope is parsed with the same independently-tolerant, size-bounded field handling as the existing body fields, is gated behind the existing origin/status/name precedence, and returns the canonical timeout classification; the added tests cover the malformed, oversized, ownership, and compaction paths. Files Reviewed (3 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 60.9K · Output: 17.2K · Cached: 1M Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Oct 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 21, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR is needed
A nested Responses API
504timeout falls through to an unknown assistant error, hiding the useful timeout explanation. This PR recognizes that envelope and uses the existing timeout classification and safe message; it does not change deadlines or retries.Summary
ca_fecb3fb25246in the existing bounded assistant-failure parser.504classification and canonical safe copy.Verification
git diff --checkpassed.This changes classification and explanation only. It does not change provider deadlines, retries, routing, or the separate
499correction. Live production and end-to-end checks were not run.