Repository navigation
fix(mobile): correct Finnish share, spend alert and query error copy - #8342
Merged
Merged
Conversation
Update six Finnish catalog values so they read as intended: - queryError.offlineTitle and queryError.serverTitle are headings and drop the terminal period, matching the periodless English titles. - share.onlyFirstFilesAttached_one uses the singular attributive so it agrees with its singular head noun. - share.searchPlaceholder names recent sessions as an open plural scope. - spendAlerts.anomalySubtitle keeps the scope's hourly rate as the subject and names its own p95 baseline. - spendAlerts.anomalyTitle uses the hourly word. Placeholders and keys are unchanged.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryCopy-only Finnish catalog update across six values in Files Reviewed (1 file)
Verification notes:
Reviewed by deepseek-v4.1-flash-1017 · Input: 40.7K · Output: 6.1K · Cached: 533.5K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Oct 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 21, 2026
…query-copy # Conflicts: # apps/mobile/src/i18n/locales/fi.json
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects six Finnish values in the mobile catalog. Value-only change: no keys, no
placeholders, no other locale. The catalog reads as follows after the change:
while the description strings keep their sentence punctuation.
scope instead of one last-used session.
head noun for the one category; the other category and the base key already inflect
the plural correctly and are unchanged.
hourly rate as the subject and names its own p95 baseline, matching the English
source and the sibling strings in the same section.
Verification
Run on the work VM against this branch:
every catalog matches English.
categories.
the commit: every changed key resolves to the new Finnish value with no English
fallback; the attachment-limit family selects the singular form at count 1 and the
plural form at count 2 with the placeholder bound; and the query-error component
renders both headings through its own variant mapping, periodless.
No screenshots: this is a copy-only catalog change with no layout effect, and the
affected surfaces sit behind authentication or a provider connection. The rendered
copy above is the observable result.
Proxy answers
The owner's proxy gave these answers in the owner's place.
spendAlerts.anomalyTitlecontainsTunneittainen piikkifor EnglishHourly spike;tunneittainenis not idiomatic Finnish (it reads fromtunne, feeling) and the hourly word should betuntikohtainen. It is not one of the approved findings. Fix it in this PR?Answer: Fix it too in the same commit
Confidence: 0.80 · Precedent: Autonomy: 'If you see a gap or an error, fix it, even if it is not related to the current task' — session 89824a222897, 'if you saw a gap, fix it'
spendAlerts.anomalySubtitle(English:This scope's hourly rate is far above its own p95 baseline). All options keep the scope's hourly rate as the subject and the statistical baseline;aluematches the sibling spendAlerts strings.Answer: Tämän alueen tuntitahti on selvästi sen oman p95-vertailutason yläpuolella
Confidence: 0.75 · Precedent: UX: 'Keep similar elements consistent across surfaces' — session a247f3c19b1e, thought row matches tool call row
share.searchPlaceholder(EnglishSearch recent sessions). The current value names one last-used session; all options use the open plural scope.Answer: Hae viimeaikaisista istunnoista
Confidence: 0.80 · Precedent: none
queryErrorheadings only need their terminal period removed.serverTitlealso has a less idiomatic verb (Lataaminen ei onnistunutvs the naturalLataus epäonnistui); the finding asks only for punctuation. Which fix?Answer: Drop the period only, keep the current words
Confidence: 0.65 · Precedent: Speed: 'Do the least work possible with no drop in quality' — session 7f3470e0ba6f, 'do the least amount of work possible, with no drop in quality'