Repository navigation
fix(bot): present platform conversation context in named prompt blocks - #8232
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the incremental commit Assumptions: Files Reviewed (2 files)
Previous Review Summaries (5 snapshots, latest commit 4948960)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 4948960)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the incremental commit Assumptions: Files Reviewed (1 file)
Previous review (commit 8496e40)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the new Assumptions: Files Reviewed (1 file)
Previous review (commit 5e2edea)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the incremental commit that removes the callback payload's over-long-summary deletion, bounds only the prompt copies of the result in both the legacy and tracked paths, and updates the tests; truncation is applied after escaping-safe helpers, the stored and chat copies intentionally retain the full text, and no correctness, security, or memory-leak issues were found. Files Reviewed (2 files)
Previous review (commit 8cbf2e7)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the incremental commit that applies Files Reviewed (3 files)
Previous review (commit 33f6e1e)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the prompt-composition refactor and Discord context sanitization across 7 files; delimiter escaping, empty-context handling, trust framing, and the new tests are consistent, and no correctness, security, or memory-leak issues were found. Files Reviewed (7 files)
Reviewed by deepseek-flash-latest · Input: 30.3K · Output: 5.2K · Cached: 270.5K Review guidance: REVIEW.md from base branch |
…ntext-delimits # Conflicts: # apps/web/src/lib/discord-bot.ts
|
bot: Follow-up check: the reported CI events belong to earlier commits. The current head, 3e0ed93, has 57 passing checks, a completed review recommending merge, and no unresolved review threads. The prior session recorded local webhook E2E proof on this same head; this follow-up did not repeat that run or change source. |
eshurakov
left a comment
There was a problem hiding this comment.
Shallow review: no critical issues found.
Evidence
Evidence: demonstrated — the real GitHub webhook route processed a locally signed fixture event and called a loopback model endpoint; the captured prompt retained one named GitHub context block as untrusted background material and kept the triggering user's message in its user turn.
Local end-to-end run on this VM at branch head
3e0ed935a927daa69398ddc6d7f595caf8c85532:POST /api/webhooks/github. GitHub API traffic and model inference were restricted to loopback fixtures. The captured model request contained exactly one GitHub context block, its expected trust framing, and the separate triggering-user message.pnpm --filter web exec jest --runInBand src/lib/bot/agent-runner.test.ts src/lib/bot/prompt.test.ts src/lib/discord-bot.test.ts src/lib/discord-bot/discord-channel-context.test.ts— 4 suites, 35 tests passed.pnpm --filter web exec jest --runInBand --testPathPatterns 'bot-session-callback/.+route\\.test\\.ts'— 1 suite, 36 tests passed.pnpm --filter web exec tsgo --noEmit --checkers 1 --tsBuildInfoFile /tmp/tsgo-web.tsbuildinfo.The change is server-side prompt composition; no visual surface is affected, so screenshots do not apply. All accounts and provider responses were local fixtures in this non-production VM.
Change
Bot prompt composition uses shared data-block formatting and keeps repository selection guidance. The shared composer and the Discord prompt describe the requesting user's role in task selection. Continuation prompt copies use the shared formatting helper and a bounded result excerpt; storage and user-visible messages retain the full result.
Existing platform context limits remain in place. The scope is prompt composition and continuation formatting; server-side authorization policy is unchanged.
Production prerequisites
None.
Proxy answers
The owner's proxy gave these answers in the owner's place.