Skip to content

fix(mobile): align Hungarian review, Kilo Pass and chat copy - #8190

Merged
iscekic merged 3 commits into
mainfrom
drain/hu-copy-fixes
Oct 22, 2026
Merged

iscekic merged 3 commits into
mainfrom
drain/hu-copy-fixes

Conversation

@iscekic

@iscekic iscekic commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Evidence

Evidence: partially demonstrated — the corrected Hungarian values and placeholder bindings were rendered through the app's own i18next in a throwaway consumer smoke run on this VM (output in Verification below), while the pre-fix strings were established by reading hu.json against en.json, not from a rendered before capture. The affected screens sit behind an authenticated, provider-connected account.

Summary

Corrects 22 Hungarian copy defects in the mobile catalog hu.json. Values only: no key, placeholder, $t() reference or edge-whitespace change, and the informal register is kept.

  • Code reviewer: the BYOK key is the subject of all three states ("érvénytelen, visszavont, vagy nincs meg a szükséges jogosultsága"); the REVIEW.md subtitle uses the catalog's repository term ("adattárankénti"); "Megfelelt" is the pass verdict; "Összevonási kapu" names the merge gate; "Kódellenőrzés" is the detail header; the retry title and settings guidance are informal like the rest of the namespace; the error template no longer doubles a stop after {{message}}; the memory title is "Kódellenőrzési memória".
  • Sign-in / consent: the passkey failure keeps the instruction to sign in with Apple, Google or email; install attribution keeps the absolute "never used" claim instead of narrowing it.
  • Credits / devices / feedback: Apple account ownership mirrors the Google Play sibling (one account term, tartoznak); the sign-out message stops calling a remote session "this device"; the feedback error uses the same app-store term as the force-update error.
  • Glanceable: generic failure is sentence-case "Leállt"; finishedIn and noActivityFor now introduce the duration their callers append, and stay distinct from the plain "Befejezve" label.
  • Kilo Pass: the load failure is stated as a load failure, "Google Play-hez" is hyphenated, and the legal link is a nominative standalone label.
  • Model chat: the token-field help is informal, "Letöltés mindenképp" reads idiomatically, and the no-fit description uses "az $t(common.all)" agreeing with the resolved "Összes".

Two of the directed fixes split a Hungarian one-wording group whose other member is an excluded-feature string that stays untouched, so the hu entry of the wording exceptions file lists review and stopped. No other language's entry changes.

Verification

Run on the work VM at commit df5f52684f:

Command Result
pnpm --filter kilo-app check:i18n oxlint 0 warnings / 0 errors; all 87 languages match the English catalog
pnpm --filter kilo-app check:plurals every counted message and every locale declares its plural categories
pnpm --filter kilo-app format:check clean; the formatter also reports both changed files as formatted
i18n vitest suites 16 files, 1609 tests passed
glanceable, code-reviewer, feedback and Kilo Pass vitest suites 50 files, 899 tests passed
pnpm --filter kilo-app run check:i18n on the merge head 0 errors; all 87 languages match the English catalog

Runtime smoke (throwaway suite, deleted before commit): the app's own i18next switched to hu, then the real consumers were driven and their output asserted:

quiet card text: Dolgozik · Nincs aktivitás ennyi ideje:
failed card text: Leállt 2026. 10. 12. 10:00
decision: Megfelelt | vote: Megfelelt
legal links: Adatvédelmi tájékoztató | Felhasználási feltételek (EULA)
finishedIn: Befejezve ennyi idő alatt: | noActivity: Nincs aktivitás ennyi ideje:
codeReviewer.actionRequired.byokInvalidKey.description
  hu: A kódellenőrző kikapcsolt, mert a kiválasztott BYOK API-kulcs érvénytelen, visszavont, vagy nincs meg a szükséges jogosultsága. Frissítsd a kulcsot, vagy válassz másik modellt, majd engedélyezd újra a kódellenőrzőt.
codeReviewer.followReviewMdSubtitle
  hu: Az adattárankénti REVIEW.md utasításfájlok követése
codeReviewer.gate.title
  hu: Összevonási kapu
codeReviewer.reviewDetail.title
  hu: Kódellenőrzés
codeReviewer.reviewDetail.retryTitle
  hu: Újrapróbálod a kódellenőrzést?
codeReviewer.reviewMemory.title
  hu: Kódellenőrzési memória
credits.purchaseOwnedByAnotherAccount
  hu: Az ezen Apple-fiókon lévő kreditek egy másik Kilo-fiókhoz tartoznak. A használatukhoz jelentkezz be abba a Kilo-fiókba.
feedback.couldNotOpenStore
  hu: Nem sikerült megnyitni az alkalmazásboltot.
glanceable.failure.other
  hu: Leállt
kiloPass.unavailable
  hu: Nem sikerült betölteni a Kilo Pass-t.
login.passkeyFailed
  hu: Ez a jelkulcs nem tudott bejelentkeztetni. Jelentkezz be inkább Apple-lel, Google-lel vagy az e-mail-címeddel.
modelChat.backends.completionTokenFieldHelp
  hu: Kimeneti tokenek mezője: modern API-k esetén a max_completion_tokens mezőt használd, vagy a max_tokens mezőt, ha a végpont a régi mezőt igényel.
modelChat.catalog.noFitsDescription
  hu: A nagyobb modellek az Összes lapon találhatók.

Placeholder binding was asserted through the real templates: Hiba történt: Boom. and Az eszköz (iPhone 15) ki lesz jelentkeztetve. Az API-hozzáférése még legfeljebb egy óráig megmaradhat.

No screenshots: this is a copy-only catalog change with no layout or code change, and the affected strings sit behind authenticated, provider-connected screens. The evidence above is the rendered consumer output, not a pixel capture.

Proxy answers

The owner's proxy gave these answers in the owner's place.

  1. Question: Exceptions file: Two directed fixes split an existing Hungarian one-wording group: reviewDetail.title → "Kódellenőrzés" (group "review" also holds prReview.review and an excluded-feature onboarding key), and glanceable.failure.other → "Leállt" (group "stopped" also holds an excluded-feature status key). The excluded member must stay untouched, so check-catalogs fails unless hu is listed for those English strings in tools/i18n/wording-exceptions.json. How should the diff handle it?
    Answer: Add 'review' and 'stopped' to the hu array
    Confidence: 0.75 · Precedent: Product scope: never touch the excluded features ("never touch the excluded features - those routes are eol and forbidden"). The exceptions entry is the minimal change that keeps both directed fixes without editing the excluded string.
  2. Question: Proof depth: This is a copy-only catalog change (no layout or code change); the affected strings sit behind authenticated, provider-connected screens (code-reviewer settings, Kilo Pass, model backends, device sessions). What end-to-end evidence should the PR carry?
    Answer: Catalog checks + real-consumer render smoke
    Confidence: 0.55 · Precedent: Speed and least work: "do the least amount of work possible, with no drop in quality"; Proof: visual proof needs a decider step ("there should be a decider step ... which determines if visual proof is needed"). For a copy-only catalog change with no layout change, rendering the strings in their real consumers is enough proof.

Correct 22 Hungarian catalog values: parallel BYOK key states, the repository
term in the REVIEW.md subtitle, verdict and gate labels, the review/retry copy
register, error placeholder punctuation, the attribution claim, Apple account
ownership wording, the device-session message, the app-store term, glanceable
failure and duration fragments, Kilo Pass load/connect/legal strings, passkey
fallback guidance, and model chat help and action labels.

Add the review and stopped wording exceptions for hu, because the untouched
excluded-feature members keep the previous wording.
@iscekic iscekic added drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks labels Oct 19, 2026
@kilo-code-bot

kilo-code-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • apps/mobile/src/i18n/locales/hu.json
  • tools/i18n/wording-exceptions.json

Reviewed by deepseek-v4.1-flash-1017 · Input: 43.9K · Output: 12.2K · Cached: 855.3K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added merge:human Substantive functional risk requires human review. merge:bot Bot-owned review; merge when ready once readiness passes and a review approves. and removed merge:human Substantive functional risk requires human review. labels Oct 20, 2026
@iscekic
iscekic enabled auto-merge October 21, 2026 15:26
@iscekic
iscekic disabled auto-merge October 21, 2026 20:40
@iscekic iscekic added merge:bot Bot-owned review; merge when ready once readiness passes and a review approves. and removed merge:bot Bot-owned review; merge when ready once readiness passes and a review approves. labels Oct 21, 2026
# Conflicts:
#	apps/mobile/src/i18n/locales/hu.json
#	tools/i18n/wording-exceptions.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks merge:bot Bot-owned review; merge when ready once readiness passes and a review approves.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants