Repository navigation
fix(mobile): align Hungarian review, Kilo Pass and chat copy - #8190
Merged
Merged
Conversation
Correct 22 Hungarian catalog values: parallel BYOK key states, the repository term in the REVIEW.md subtitle, verdict and gate labels, the review/retry copy register, error placeholder punctuation, the attribution claim, Apple account ownership wording, the device-session message, the app-store term, glanceable failure and duration fragments, Kilo Pass load/connect/legal strings, passkey fallback guidance, and model chat help and action labels. Add the review and stopped wording exceptions for hu, because the untouched excluded-feature members keep the previous wording.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 43.9K · Output: 12.2K · Cached: 855.3K Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Oct 20, 2026
iscekic
enabled auto-merge
October 21, 2026 15:26
iscekic
disabled auto-merge
October 21, 2026 20:40
# Conflicts: # apps/mobile/src/i18n/locales/hu.json # tools/i18n/wording-exceptions.json
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence
Evidence: partially demonstrated — the corrected Hungarian values and placeholder bindings were rendered through the app's own i18next in a throwaway consumer smoke run on this VM (output in Verification below), while the pre-fix strings were established by reading
hu.jsonagainsten.json, not from a rendered before capture. The affected screens sit behind an authenticated, provider-connected account.Summary
Corrects 22 Hungarian copy defects in the mobile catalog
hu.json. Values only: no key, placeholder,$t()reference or edge-whitespace change, and the informal register is kept.{{message}}; the memory title is "Kódellenőrzési memória".tartoznak); the sign-out message stops calling a remote session "this device"; the feedback error uses the same app-store term as the force-update error.finishedInandnoActivityFornow introduce the duration their callers append, and stay distinct from the plain "Befejezve" label.Two of the directed fixes split a Hungarian one-wording group whose other member is an excluded-feature string that stays untouched, so the hu entry of the wording exceptions file lists
reviewandstopped. No other language's entry changes.Verification
Run on the work VM at commit
df5f52684f:pnpm --filter kilo-app check:i18npnpm --filter kilo-app check:pluralspnpm --filter kilo-app format:checkpnpm --filter kilo-app run check:i18non the merge headRuntime smoke (throwaway suite, deleted before commit): the app's own i18next switched to
hu, then the real consumers were driven and their output asserted:Placeholder binding was asserted through the real templates:
Hiba történt: Boom.andAz eszköz (iPhone 15) ki lesz jelentkeztetve. Az API-hozzáférése még legfeljebb egy óráig megmaradhat.No screenshots: this is a copy-only catalog change with no layout or code change, and the affected strings sit behind authenticated, provider-connected screens. The evidence above is the rendered consumer output, not a pixel capture.
Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: Add 'review' and 'stopped' to the hu array
Confidence: 0.75 · Precedent: Product scope: never touch the excluded features ("never touch the excluded features - those routes are eol and forbidden"). The exceptions entry is the minimal change that keeps both directed fixes without editing the excluded string.
Answer: Catalog checks + real-consumer render smoke
Confidence: 0.55 · Precedent: Speed and least work: "do the least amount of work possible, with no drop in quality"; Proof: visual proof needs a decider step ("there should be a decider step ... which determines if visual proof is needed"). For a copy-only catalog change with no layout change, rendering the strings in their real consumers is enough proof.