Skip to content

feat(auto-routing): graduate custom routers and remove the rollout flag - #8161

Merged
iscekic merged 2 commits into
mainfrom
feat/graduate-custom-routers-flag
Oct 21, 2026
Merged

iscekic merged 2 commits into
mainfrom
feat/graduate-custom-routers-flag

Conversation

@iscekic

@iscekic iscekic commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Custom routers (kilo-auto/custom/*) are now available to every user. The kilo-auto-custom-routers release flag is rolled out to everyone, and this change removes it from the code.

  • listUsableCustomRouters returns all personal and organization routers, not only migrated pools.
  • The custom-router API no longer hides unmigrated routers or blocks router creation for unflagged users.
  • The profile page always shows the custom routers card.
  • isCustomRoutersEnabled, hasLegacyPoolAccess, and hasCustomRoutersAccess are removed.
  • ADR 0005 records that the flag graduated before the pool cutover.

Scope

This change does not touch the pool cutover in the separate graduation PR. Legacy pool rows keep their protections: the migrated slug stays fixed and the router cannot be deleted until the cutover.

Verification

  • The web package type check passes.
  • The route and shared-module tests now check that routers stay available without the flag. CI runs them against the database.

@kilo-code-bot

kilo-code-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental change clears mockedRequireActiveSubscription before the inherited-editor PATCH, so the assertion at line 398 once again isolates the update path's subscription check; the implementation is unmodified and the previous finding is resolved.

Files Reviewed (1 file)
  • apps/web/src/app/api/auto-routing/custom-routers/route.test.ts
Previous Review Summary (commit 9fa7300)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 9fa7300)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The flag removal is consistent across the API, shared helpers, UI, and callers; the only finding is a test assertion whose subscription-check coverage was silently weakened by the removal.

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
apps/web/src/app/api/auto-routing/custom-routers/route.test.ts 397 The requireActiveSubscriptionOrTrial assertion is now satisfied by the preceding org router creates, so it no longer proves the PATCH path enforces the subscription. Clear the mock after the creates or assert the call count around the update.
Files Reviewed (7 files)
  • apps/web/src/app/(app)/profile/page.test.ts
  • apps/web/src/app/(app)/profile/page.tsx
  • apps/web/src/app/api/auto-routing/custom-routers/route.test.ts - 1 issue
  • apps/web/src/lib/auto-routing-custom-routers.ts
  • docs/adr/0005-custom-auto-routers.md
  • packages/web-shared/src/lib/ai-gateway/custom-routers.test.ts
  • packages/web-shared/src/lib/ai-gateway/custom-routers.ts

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash-1017 · Input: 29.4K · Output: 2.3K · Cached: 193.2K

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic requested a review from pandemicsyn October 19, 2026 22:03
@iscekic
iscekic enabled auto-merge October 21, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants