Skip to content

fix(auto-routing): skip unreachable owners in the pool notice - #8129

Merged
iscekic merged 1 commit into
mainfrom
fix/pool-notice-unreachable
Oct 19, 2026
Merged

iscekic merged 1 commit into
mainfrom
fix/pool-notice-unreachable

Conversation

@iscekic

@iscekic iscekic commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Discovery now ignores soft-deleted users as personal owners and as direct or inherited organization billing contacts. It uses the soft-delete marker in the blocked reason, not the email domain.

An owner with no live, valid contact no longer stops the campaign. The plan saves a private hash of the owner, and the dry-run and send outputs report the unreachable count. Invalid contact emails are dropped; the owner becomes unreachable only when no valid contact remains.

Ordinary dry runs and sends reject a changed set of unreachable owners until a refresh saves it. All other plan checks stay the same. The help text and the ADR operator section describe the new behavior.

Verification: web typecheck, oxlint on the changed files, and both pool notification Jest suites with the test database.

@kilo-code-bot

kilo-code-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • apps/web/src/lib/auto-routing-pool-notification-discovery.test.ts
  • apps/web/src/lib/auto-routing-pool-notifications.test.ts
  • apps/web/src/scripts/lib/auto-routing-pool-notification-discovery.ts
  • apps/web/src/scripts/lib/auto-routing-pool-notifications.ts
  • apps/web/src/scripts/notify-auto-routing-pool-users.ts
  • docs/adr/0005-custom-auto-routers.md

Reviewed by deepseek-v4.1-flash-1017 · Input: 88.1K · Output: 23.8K · Cached: 1.4M

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants