Repository navigation
fix(mobile): surface review service outages with their own localized state - #8100
Conversation
…state A BAD_GATEWAY from the PR review read paths now classifies as service-unavailable instead of joining the generic retryable bucket, so the overview, files, discussion, checks, navigator and inbox surfaces name the unavailable review service rather than reporting a GitHub failure. Every arm keeps its retry affordance. All 87 locale catalogs carry the new key. The hermetic local GitHub stub moves back under apps/mobile/e2e and its GraphQL dispatcher now answers the PR review inbox search with the fixture pull requests, so a local stack renders the entry inbox without reaching GitHub.
iscekic
added
drain
|
bot: End-to-end verification on the Android emulator against the local stack with the local GitHub stub.
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commit only extends Assumptions: Files Reviewed (1 file)
Previous Review Summaries (9 snapshots, latest commit e82aded)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e82aded)Status: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commit extracts the diff file list's first-page error states into a dedicated component; the state dispatch, provider scoping, and retry wiring are preserved, and no new issues were found. Files Reviewed (4 files)
Previous review (commit 3135cd2)Status: No Issues Found | Recommendation: Merge Executive SummaryThe only incremental change is the Welsh outage description, which now correctly negates availability; the previously reported translation finding is resolved with no new issues. Files Reviewed (1 file)
Previous review (commit 4b6b2d5)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe Welsh outage description still tells users the review service is temporarily available; the Somali retry clause is now fixed. Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous review (commit e9419ab)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe Somali retry clause remains untranslated, and the Welsh description still tells users the review service is available during an outage. Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Previous review (commit 819f09a)Status: 5 Issues Found | Recommendation: Address before merge Executive SummaryThe new description is wired correctly into all six surface components, but five of the newly added catalog strings are wrong, including a Welsh translation that tells users the service is available during an outage. Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (93 files)
Previous review (commit 2d39f8f)Status: No Issues Found | Recommendation: Merge Executive SummaryThe incremental change fixes the previously reported overview regression: Files Reviewed (1 file)
Incremental scope: Previous review (commit ce615ec)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe discussion-tab retained-content fix landed, but the overview's cached-data carve-out still excludes Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Incremental scope: Fix these issues in Kilo Cloud Previous review (commit 870e942)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe follow-up commits only broaden comments and flatten the overview title ternary; the two cached-content regressions from the new Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Incremental scope: Fix these issues in Kilo Cloud Previous review (commit 6f97930)Status: 3 Issues Found | Recommendation: Address before merge Executive SummaryThe latest commit only flattens the overview error-title ternary; the new Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
Incremental scope: Reviewed by deepseek-flash-latest · Input: 53.7K · Output: 4.1K · Cached: 638.5K Review guidance: REVIEW.md from base branch |
Splits the nested ternary into statements so the linter passes.
BAD_GATEWAY also carries GitHub 5xx and provider transport failures, so the classifier and overview comments describe all three sources instead of only the authorization layer.
…lure The discussion tab's retained-content guard now covers the service-unavailable state alongside retryable, so already-loaded threads render through the later-page retry footer instead of a tab-level blank.
…h failure The overview's cached-data carve-out now covers service-unavailable alongside retryable, mirroring the discussion tab: a failed background refetch of an already-loaded pull request no longer blanks the screen.
The new state renders its own body line instead of the generic server-error description. All 87 locale catalogs carry the key, and every surface that renders the state passes it as the message.
iscekic
added
merge:human
|
bot: Follow-up verification after the description was added to the outage state, plus recovery proofs.
|
Fixes the Welsh polarity, the Somali and Oromo wording, the Estonian word form, and the Icelandic compounding flagged in review.
The description now states the service is temporarily unavailable, matching the title.
iscekic
added
merge:human
…der-failure-states # Conflicts: # apps/mobile/src/i18n/locales/hu.json
iscekic
added
merge:bot
The list module keeps its layout and pagination wiring; the terminal and recoverable first-page states render from their own component.
iscekic
removed
the
merge:bot
The gateway-failure body renders the outage copy rather than the server default, and both retryable bodies reach the query refetch.
iscekic
added
the
merge:bot
bot: ## Change
Opening a GitHub pull request in the mobile PR review screen could end in the
generic server-error state with a retry that never succeeded: when the review
read path's authorization layer is temporarily unavailable, the read fails with
BAD_GATEWAY, which previously joined the generic retryable bucket and rendered
as a GitHub-side failure.
The PR review error classifier now maps BAD_GATEWAY to its own
service-unavailablestate with its own title and description. The overview,files tab, discussion tab, checks section, file navigator, inbox, and entry
surfaces render the dedicated copy for it, keeping the retry affordance.
BAD_GATEWAY carries every retryable gateway-class failure — the authorization
layer in front of GitHub, a GitHub 5xx, and provider transport failures — so
those now show this state; the not-found, permission, and reconnect states are
unchanged. All 87 locale catalogs carry both new keys.
The hermetic local GitHub stub for PR-review E2E moves back under
apps/mobile/e2e/, and its GraphQL dispatcher now answers the PR review inboxsearch with the fixture pull requests, so a local stack renders the entry
inbox without reaching GitHub.
End-to-end verification (Android emulator, local stack, stub GitHub)
sections; Files tab lists changed files; selecting a line opens the write
bar; Comment opens the composer with context preview, body field and
Comment now / Add to review.
disabled.
check-connection flow on both the entry and detail surfaces.
the new "Review service unavailable" state with its own description (not
the generic server error); Retry after recovery loads the data.
Unit tests: classifier, inbox and discussion view selectors, and the full
PR-review suites (144 files, 3009 tests) pass; catalog and plural checkers
pass for all 87 locales.
Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: Dedicated state (Recommended)
Confidence: 0.70
Answer: Restore with inbox (Recommended)
Confidence: 0.60
Answer: Full matrix (Recommended)
Confidence: 0.75
Answer: Review service (Recommended)
Confidence: 0.70
Answer: Shared classifier (Recommended)
Confidence: 0.88
Answer: apps/mobile/e2e (Recommended)
Confidence: 0.75
Answer: All locales (Recommended)
Confidence: 0.93