Repository navigation
fix(auto-routing): post owner pool conversions with a redirect mode Workers accept - #8098
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 51.9K · Output: 9.8K · Cached: 488.7K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Oct 19, 2026
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The silent pool conversion could not write anything in production. The first
--applypage aborted withbatch_failed, and no rows were created.Cause
postOwnerPoolConversionscalledfetchwithredirect: 'error'. The Workers runtime rejects that value with aTypeErrorbefore it opens a connection, and the function'scatchreturnednullwithout a trace. The dry run never posts, and the unit tests run in Node with a mockedfetch, so neither caught it. The same function backsmigrateOwnerPoolForSettings, so pool saves that should convert also returned no outcome.Changes
redirect: 'manual'. A 3xx response is notok, so the internal secret still never follows a redirect and the batch fails closed. A test covers a 307 response.auto_routing_owner_pool_conversion_post_failed) with its stage, status and batch size. No headers, secret or owner payload are logged.nullfor the optional fields of Cloudflare API responses. The object listing returnserrors: null, which failed the dry run at its first request.Verification
services/auto-routing:owner-pool-conversion.test.tspasses, and typecheck and oxlint pass.redirect: 'error'throws,redirect: 'manual'passes option validation.