Repository navigation
fix(auto-routing-benchmark): finalize runs whose only pending work is dead lanes - #8075
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Reviewed the extracted shared unsettled-chunk SQL predicate and the new Files Reviewed (4 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 83.4K · Output: 19.5K · Cached: 1.6M Review guidance: REVIEW.md from base branch |
…-run-sweep # Conflicts: # services/auto-routing-benchmark/src/run.ts # services/auto-routing-benchmark/src/scheduler.ts
eshurakov
approved these changes
Oct 19, 2026
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduler's settled-run sweep looked for running decider runs with no pending, queued or active chunk. Chunks of a dead-lettered lane can stay pending forever, so a run whose only remaining work belonged to dead lanes was never finalized: no live chunk was left to trigger per-completion finalization.
The sweep now uses the same unsettled-chunk rule as
hasUnsettledChunks, which ignores chunks of lanes recorded inrun_lane_failures. The rule is one shared SQL fragment, so the two checks cannot drift apart.Verification
pnpm typecheck,pnpm lintand the full vitest suite inservices/auto-routing-benchmarkon a work VM. All passed.scheduler_chunksnorrun_lane_failures.