Repository navigation
fix(web): remove unused internal diagnostic endpoint - #7989
Conversation
The endpoint served no purpose in production: it was not referenced by any client, test, or script, and duplicated behavior already available through the authenticated code-indexing routes.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe PR deletes a single unused, unauthenticated diagnostic route ( Files Reviewed (1 file)
Verification notes: the deletion removes the whole Reviewed by deepseek-v4.1-flash · Input: 39.2K · Output: 2.2K · Cached: 200.1K Review guidance: REVIEW.md from base branch |
bot: Removes an unused internal diagnostic API route from the web app.
Change
apps/web/src/app/api/milvus/test/route.ts(the wholeapps/web/src/app/api/milvus/directory; it contained only that file).MilvusIndexStorage,getMilvusClient, andcreateEmbeddingServiceremain in use by the authenticated code-indexing routers.Route surface review
Per review request, all route handlers under
apps/web/src/app/api/were checked against the standing requirement that each endpoint touching server state or credentials enforces authentication or a service-to-service secret:Verification
pnpm --filter web typecheckpasses on the branch (tsgo, no errors).GET /api/milvus/test?embed=hello&search=world→ 404 (route gone).GET /api/defaults→ 200 (server live, other routes unaffected).GET /api/up→ live JSON health response.Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: Widen scope
Confidence: 0.50 · Precedent: Fix the root cause and the class of the issue: session 00eb2a1d3e4b, "if anything repeats the same mistake over and over again, fix the class"; session 89824a222897, "if you saw a gap, fix it"
Answer: Local 404 check (Recommended)
Confidence: 0.85 · Precedent: Run only the tests and lint for touched files: session 30e048f42118, "never run the full test suite, leave that for CI"