Repository navigation
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The PR applies the existing transport-identity and framing-header rules consistently across the static and auxiliary header schemas and the upstream header builder, with matching unit tests. The change is additive and the two validation layers agree on what may reach the remote server. Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 41.3K · Output: 5.6K · Cached: 249K Review guidance: REVIEW.md from base branch |
|
bot: Closing as superseded. The MCP Gateway package this branch modifies was removed from |
Pull request was closed
Auxiliary header configuration now follows the same validation rules as static header configuration: names that identify transport-level metadata are refused, and message framing headers are refused for both header kinds. The upstream request builder independently skips those names in auxiliary input, so the two layers agree on what may reach a remote server.
Verification
pnpm --filter @kilocode/mcp-gateway test: 46 passed (new cases cover refusal of transport identity names and content-length in both header maps, and the upstream builder skipping them in auxiliary input).pnpm --filter @kilocode/mcp-gateway typecheck: clean.pnpm --filter @kilocode/mcp-gateway lint: 0 warnings, 0 errors.Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: Mirror in static schema too
Confidence: 0.50 · Precedent: Fix the root cause and the class of the issue on every affected surface: session 00eb2a1d3e4b, "if anything repeats the same mistake over and over again, fix the class"; also "if you saw a gap, fix it" (session 89824a222897)
Answer: content-length only, both schemas (Recommended)
Confidence: 0.70 · Precedent: Do the least work possible with no drop in quality: session 00eb2a1d3e4b, "skip work that doesn't need to be done". transfer-encoding is already covered by the hop-by-hop rule, and content-type is legitimate.
Answer: Accept behavior change (Recommended)
Confidence: 0.65 · Precedent: Fix the root cause and the class of the issue on every affected surface: session 7f3470e0ba6f, "fix class of issue preventing progress". Parse errors already fail closed.
Answer: Skip both (Recommended)
Confidence: 0.75 · Precedent: Fix the root cause and the class of the issue: session 00eb2a1d3e4b, "if anything repeats the same mistake over and over again, fix the class". The brief also asks buildUpstreamHeaders to skip transport identity names, and a runtime guard for framing names covers callers that pass raw maps.