Skip to content

fix(web): tighten findings list filtering - #7789

Merged
pandemicsyn merged 1 commit into
mainfrom
fix/findings-list-consistency
Oct 16, 2026
Merged

pandemicsyn merged 1 commit into
mainfrom
fix/findings-list-consistency

Conversation

@pandemicsyn

Copy link
Copy Markdown
Contributor

Summary

  • Refine findings list filtering and response validation.
  • Add regression coverage for filtered results, counts, and pagination.

Verification

  • Manually inspected generated SQL. No browser testing performed for this backend-only change.

Visual Changes

N/A

Reviewer Notes

  • Web typecheck, targeted lint, formatting, and diff checks passed.
  • Database-backed test suites were attempted but blocked by unavailable local PostgreSQL.
  • No schema migration or API response-shape changes.

@pandemicsyn
pandemicsyn enabled auto-merge October 16, 2026 19:31
@kilo-code-bot

kilo-code-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

This PR correctly parenthesizes the sandboxAnalysis.isExploitable OR-condition in listSecurityFindings (fixing an operator-precedence leak that could return rows outside the owner/status filter) and adds a fail-closed ownership guard in the list handler with matching regression coverage; no defects found.

Files Reviewed (4 files)
  • apps/web/src/lib/security-agent/db/security-findings.ts
  • apps/web/src/lib/security-agent/db/security-findings.test.ts
  • apps/web/src/lib/security-agent/router/shared-handlers.ts
  • apps/web/src/lib/security-agent/router/shared-handlers.test.ts

Reviewed by deepseek-v4.1-flash · Input: 57.9K · Output: 8.5K · Cached: 593.2K

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants