Repository navigation
fix(ai-gateway): fail custom LLM requests cleanly when credentials cannot be resolved - #7779
Closed
chrarnoldus wants to merge 1 commit into
Closed
chrarnoldus wants to merge 1 commit into
chrarnoldus wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe custom LLM credential-failure handling is correct and consistently wired: decryption/schema failures fall through like the existing invalid-credentials case, service-account token-exchange failures produce a new Files Reviewed (4 files)
Notes
Reviewed by deepseek-v4.1-flash · Input: 59.5K · Output: 16.8K · Cached: 842.1K Review guidance: REVIEW.md from base branch |
1 task
Contributor
Author
|
We don't want this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two failures in custom LLM credential resolution threw out of
getProvider, andhandleLlmProxyRequestturned them into a 500:BYOK_ENCRYPTION_KEYor corrupted ciphertext). These are now treated like the existing invalid-credentials case: logged, with the custom LLM skipped.custom-llm-temporarily-unavailableresult, which the proxy answers with a 503. The user learns to retry instead of getting an internal error.This is a prep PR for #7291.
Verification
Visual Changes
N/A
Reviewer Notes
The error log includes only the public id and the error message, never credentials.