Repository navigation
fix(mobile): declare iOS memory entitlements for every build profile - #7750
Merged
Merged
Conversation
llama.rn adds the extended-virtual-addressing and increased-memory-limit entitlements only under the production profile. A development build or an eas credentials run then syncs the com.kilocode.kiloapp App ID without them, EAS disables both capabilities, and the regenerated App Store profile no longer matches the production entitlements.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commit only rewords the Files Reviewed (1 file)
Notes
Previous Review Summary (commit 3c083cd)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3c083cd)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe iOS entitlement fix is functionally sound for the EAS App ID sync; the only finding is an inaccurate plugin-option comment in Overview
Issue Details (click to expand)SUGGESTION
Fix these issues in Kilo Cloud Files Reviewed (1 file)
Notes
Reviewed by deepseek-v4.1-flash · Input: 35.7K · Output: 3.4K · Cached: 174.3K Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Oct 16, 2026
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
kilo-app ReleaseiOS build fails since yesterday evening. Xcode rejects the App Store profile forcom.kilocode.kiloapp: the profile does not include the Extended Virtual Addressing and Increased Memory Limit capabilities.Root cause:
llama.rnconfig plugin addscom.apple.developer.kernel.extended-virtual-addressingandcom.apple.developer.kernel.increased-memory-limitonly whenEAS_BUILD_PROFILEisproduction.developmentbuild or aneas credentialsrun evaluates the config without these entitlements.This change declares both entitlements in
ios.entitlementsfor every profile and turns off the plugin's profile-dependent copy (enableEntitlements: false). Production entitlements do not change.Follow-up outside the repository
The CI build does not sync capabilities for the main target. In eas-cli, the App Store Connect key loads only after the first target is set up. So the App ID still needs the two capabilities turned on again once, with an interactive Apple login.
Verification
npx expo config --jsonnow resolves both entitlements for no profile,development, andproduction. Onmain, no profile anddevelopmentresolve neither entitlement.pnpm assert:configwithEAS_BUILD_PROFILE=productionpasses.