Repository navigation
[AISAGE-503] feat(usage-ingest): bound queue retries and concurrency - #7722
Merged
Merged
Conversation
johnnyeric
commented
Oct 16, 2026
| // Unused by the Worker: ensures Wrangler provisions the DLQ on deployment. | ||
| { "binding": "USAGE_INGEST_DLQ", "queue": "usage-ingest-processing-dlq" }, | ||
| ], | ||
| "consumers": [ |
Contributor
Author
There was a problem hiding this comment.
Conservative values - will adjust after testing.
johnnyeric
marked this pull request as ready for review
October 16, 2026 10:28
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Queue-consumer bounding ( Files Reviewed (4 files)
Notes (not defects, no action required):
Reviewed by deepseek-v4.1-flash · Input: 60.3K · Output: 16.8K · Cached: 604.9K Review guidance: REVIEW.md from base branch |
iscekic
approved these changes
Oct 16, 2026
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound receipt-consumer delivery to one message per batch and one active invocation in each environment, with no batch-fill wait, three retries and a 60-second retry delay. Route exhausted failures to separate production/staging DLQs; unused producer bindings let pinned Wrangler provision those queues declaratively.
Document the queue policy, declarative provisioning bindings, and retention configuration. Receipt-only ACK behavior is unchanged, including malformed-message discard; direct usage writes remain authoritative.
Verification
Automated checks
createTestHarnessruns the configured Worker in workerd/Miniflare for both environments, covering HTTP publish → queue → receipt → ACK and malformed-message discard.wrangler deploy --dry-runbuilds passed with the correct environment-specific source and DLQ bindings.Recorded local retry/DLQ log
Output from the isolated synthetic fixture described above; the diagnostic DLQ consumer acknowledges forwarded messages.
Visual Changes
N/A
Reviewer Notes
The production concurrency ceiling of one is an initial conservative bound, not measured capacity. Retry delay adds about three minutes before a promptly failing message reaches the DLQ, plus execution/scheduling time. Local emulation does not enforce hosted consumer concurrency.
Wrangler 4.135.0 cannot encode retention in this config; four-day retention must be set and verified separately at deployment. No DLQ consumer is attached. A DLQ retains exhausted failures within retention; it does not retain acknowledged malformed messages or turn receipt consumption into billing recovery.