Repository navigation
(janitor/comments) remove section banners and narration comments in cloud-agent-next - #7712
Merged
Merged
Conversation
…loud-agent-next Delete 50 comment lines that only restated code or served as visual separators: 45 '// ---' section banners across the control-plane DOs, schemas, shared protocol, and ingest tests, plus narration lines restating the DO-name parse, the /ingest route dispatch, and the server-push-only stream handling. No behavior change.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryComment-only cleanup across 9 Files Reviewed (9 files)
Reviewed by deepseek-v4.1-flash · Input: 38.5K · Output: 3.1K · Cached: 179.6K Review guidance: REVIEW.md from base branch |
Contributor
Author
|
Meta Janitor: Safety review passed; requesting approval. |
Contributor
There was a problem hiding this comment.
Meta-janitor safety approval for 57f9c65. Signal: #7712 (comment). GitHub auto-merge remains responsible for merging.
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package or topic area cleaned
services/cloud-agent-next(Cloud Agent Next Worker — control-plane DOs, schemas, shared protocol, ingest tests).Files touched (9)
src/control-plane/sandbox/sandbox-do.ts(14)src/control-plane/session/session-do.ts(16)src/control-plane/sandbox/routes.ts(2)src/persistence/schemas.ts(3)src/persistence/CloudAgentSession.ts(5)src/session/session-registration.ts(2)src/shared/control-plane-protocol.ts(1)src/shared/runtime-profile.ts(2)src/websocket/ingest.test.ts(5)Comment lines removed: 50
(diff total is 95 deletions; the other 45 are blank-line collapses directly resulting from banner removal)
Categories of noise removed
// --- lifecycle entry points ---style, 45 lines) — the method names and JSDoc already convey the grouping, and the spec tags on banners ((B10),(spec §10)) are duplicated in the adjacent JSDoc of the methods they labeled.src/persistence/schemas.ts, the banner's "(read-only fallback, no longer written)" note was already covered by the JSDoc immediately above ("retained only for legacy record parsing").Important comments intentionally retained
The area was sampled broadly first; nearly all comments in this service are high-quality "why" comments (spec references, failure/recovery rationale, security notes, external-platform behavior). All of those are untouched, including the spec-section JSDoc contracts, ledger/admission rationale in
session-registration.ts, and thelastIndexOf(':')userId-with-colons invariant inCloudAgentSession.ts.Follow-up refactor candidates
None — every removed comment was replaced by nothing because no symbol required narration to be understood.
Validation
pnpm run lint(oxlint): 0 warnings, 0 errorspnpm run typecheck(tsgo + wrapper): exit 0pnpm run test(unit, Vitest): 224 files, 6808 passed / 3 skippedpnpm run format:checkfails on 4 pre-existing drizzlemeta/*.jsonfiles on a clean tree too; none of the 9 touched files are flagged