Repository navigation
feat(auto-routing): resolve model aliases before benchmarking - #7582
Merged
Merged
Conversation
eshurakov
approved these changes
Oct 15, 2026
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe alias-sanitization fix resolves both prior catalog-parsing defects; one advisory serving-worker allow-list concern remains in the unchanged Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit 18321a8)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 18321a8)Status: 3 Issues Found | Recommendation: Address before merge Executive SummaryA new Overview
Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Files Reviewed (12 files)
Reviewed by deepseek-v4.1-flash · Input: 67.7K · Output: 16.3K · Cached: 956.9K Review guidance: REVIEW.md from base branch |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
alias_targetslugs for~aliases in the model catalog.Rollout
Deploy the auto-routing serving worker first, then the auto-routing-benchmark worker. Older serving workers filter concrete custom-table candidates against saved alias ids. The new serving worker supports both existing alias-id tables and new concrete-id tables; both shapes have regression coverage. Publish the gateway catalog field before expecting alias resolution to take effect.
Verification
platform-models,admin,orphan-claim-sql,profile-runs,custom-routing-table— 128 tests passed, including real SQLite retarget reconciliation and concrete-id publication/pricing.src/index.test.ts— 104 tests passed, including old/new benchmark-worker custom-table compatibility.index.test.ts— 34 Jest tests passed using the web configuration with database worker setup omitted for this unit-only run. Includes upstream object/absent alias metadata, database overwrite, and omission of upstream-only alias targets. The local test database was not running; existing optional benchmark-summary lookups emitted connection-refused warnings and used their normal fallback.pnpm --filter auto-routing-benchmark typecheck,pnpm --filter auto-routing typecheck, andpnpm --filter @kilocode/web-shared typecheck— passed.pnpm format:changedand staged whitespace check — passed.No production benchmark was started. CI and review are not awaited.