Repository navigation
feat(session-ingest): accept worktree-scoped Cloud Agent requests - #7489
Merged
Merged
Conversation
This was referenced Oct 13, 2026
eshurakov
force-pushed
the
eshurakov/spry-rapids-1-session-ingest
branch
from
October 13, 2026 21:11
9a2d2d3 to
d4ac6bf
Compare
eshurakov
marked this pull request as ready for review
October 14, 2026 09:28
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (12 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit d4ac6bf)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d4ac6bf)Status: No Issues Found | Recommendation: Merge Executive SummaryI reviewed the 8-file v2 worktree-scope change across the contracts, the session-ingest route/service layer, and its tests, and found no high-confidence bugs or security gaps; the v2 authorization fails closed and consistently scopes every lookup by owner, organization, and worktree. Files Reviewed (8 files)
Notes / assumptions:
Reviewed by deepseek-v4.1-flash · Input: 269.8K · Output: 37.4K · Cached: 2.6M Review guidance: REVIEW.md from base branch |
Resolve authorized descendants with one bounded recursive query. Validate owner and worktree boundaries, cycle handling, and depth limits against PostgreSQL.
eshurakov
force-pushed
the
eshurakov/spry-rapids-1-session-ingest
branch
from
October 15, 2026 09:58
d4ac6bf to
8bdfeab
Compare
chrarnoldus
approved these changes
Oct 15, 2026
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of 3 in a stack that splits the change "share worktree runtimes with scoped credentials":
The Cloud Agent session-scope receiver now accepts a v2 scope assertion. The v2 headers name a worktree, the expected organization and the member root Kilo sessions (at most 32 roots, and at most 4096 bytes for the header block). One handle can then serve every session in the member trees of that worktree.
services/session-title.ts, so the public route and the scoped route use the same code.This PR can deploy alone. It is step 1 of the rollout in
services/cloud-agent-next/docs/control-plane.md: session-ingest must accept v2 before the Worker sends it. No caller sends v2 headers before #7491.Verification
Visual Changes
N/A
Reviewer Notes
SessionExportResultAPI from feat(session-ingest): clone and export a session up to a message #7439.