Repository navigation
Apply October 9 UTC cutoff to monthly Kilo Pass welcome bonuses - #7284
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental change adds a single clause to referral rule 120 in Files Reviewed (1 file)
Previous Review Summaries (4 snapshots, latest commit 3d1502f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3d1502f)Status: No Issues Found | Recommendation: Merge Executive SummaryThe follow-up makes the welcome-month issuance free of referral rewards by deferring a pending referral bonus when a monthly invoice pays the 50% welcome promo, extracts a shared Files Reviewed (7 files)
Previous review (commit b7b370c)Status: No Issues Found | Recommendation: Merge Executive SummaryThe follow-up rewrites the monthly welcome-bonus schedule to select month 1 or month 2 from the subscription start timestamp against the 2026-10-09 UTC cutoff, removes the stored schedule flag and its unshipped migration, and keeps the grant logic, ramp dialog, and upsell/preview copy consistent; the prior findings remain resolved and no new issues were found in the changed lines. Files Reviewed (33 files)
Previous review (commit 70fc5da)Status: No Issues Found | Recommendation: Merge Executive SummaryThe follow-up commit gates the yearly upsell copy on the selected cadence and bounds the welcome-promo callout to the applicable streak-month window; all five prior findings are resolved and no new issues were found in the changed lines. Files Reviewed (5 files)
Previous review (commit b022db5)Status: 5 Issues Found | Recommendation: Address before merge Executive SummaryThe core bonus migration is correct and well-tested; the remaining issues are user-facing copy/logic that now misstates the schedule on the Yearly cadence and a welcome-promo callout shown after the promo window. Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (30 files)
Reviewed by deepseek-v4.1-flash · Input: 30.8K · Output: 2.2K · Cached: 198.8K Review guidance: REVIEW.md from base branch |
A pending referral reward filled the month-2 issuance bonus slot. Starts at or after the October 9 cutoff then lost the month-2 welcome promo. The reward now waits for the next eligible issuance, for referees and referrers.
Monthly behavior
Cutoff: 2026-10-09 00:00:00 UTC, based on the subscription's original start timestamp.
getStateagain shows the welcome promo to users with no subscription. feat(mobile): add Apple Kilo Pass purchases #3079 changed this tofalseon May 13.Verification
stripe-handlers-invoice-paid.test.tspassed 58 tests. The usage-triggered, issuance, and bonus suites passed 84 tests.Deployment
Deploy the application before the cutoff. The subscription start timestamp selects the welcome month, not the deployment time.