Skip to content

Fully remove verified domains, post data-cleanup - #7211

Merged
intentionally-left-nil merged 1 commit into
mainfrom
finish-verified-domain-cleanup
Oct 8, 2026
Merged

intentionally-left-nil merged 1 commit into
mainfrom
finish-verified-domain-cleanup

Conversation

@intentionally-left-nil

Copy link
Copy Markdown
Contributor

Summary

Now that the data migration is complete, we can remove the cron job, and also drop the verified_domains table. Although verified domains are possibly useful for SSO, no code is reading or writing to this table, so it's better to delete the table. We can start over again later if we bring the feature back

@kilo-code-bot

kilo-code-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The verified-domain removal is complete and consistent: the cron route, cleanup library/tests, and vercel.json schedules are gone, no application code references organization_domain_claims, the schema table and its exports are removed, and the migration snapshot chain is valid.

Files Reviewed (9 files)
  • packages/db/src/migrations/0273_fast_sandman.sql
  • packages/db/src/migrations/meta/0273_snapshot.json
  • packages/db/src/migrations/meta/_journal.json
  • packages/db/src/schema.ts
  • apps/web/vercel.json
  • apps/web/src/app/api/cron/cleanup-verified-domain-claims/route.ts (deleted)
  • apps/web/src/app/api/cron/cleanup-verified-domain-claims/route.test.ts (deleted)
  • apps/web/src/lib/organizations/verified-domain-cleanup.ts (deleted)
  • apps/web/src/lib/organizations/verified-domain-cleanup.test.ts (deleted)
Previous Review Summary (commit 60d2cbd)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 60d2cbd)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Verified the verified-domain cleanup removal is complete: no remaining application references to organization_domain_claims or its removed exports, the migration snapshot chain is consistent, and vercel.json remains valid.

Files Reviewed (9 files)
  • packages/db/src/migrations/0270_drop_organization_domain_claims.sql
  • packages/db/src/migrations/meta/0270_snapshot.json
  • packages/db/src/migrations/meta/_journal.json
  • packages/db/src/schema.ts
  • apps/web/vercel.json
  • apps/web/src/app/api/cron/cleanup-verified-domain-claims/route.ts (deleted)
  • apps/web/src/app/api/cron/cleanup-verified-domain-claims/route.test.ts (deleted)
  • apps/web/src/lib/organizations/verified-domain-cleanup.ts (deleted)
  • apps/web/src/lib/organizations/verified-domain-cleanup.test.ts (deleted)

Reviewed by deepseek-v4.1-flash · Input: 51.6K · Output: 6.4K · Cached: 690.6K

Review guidance: REVIEW.md from base branch main

@intentionally-left-nil
intentionally-left-nil force-pushed the finish-verified-domain-cleanup branch from 5d6b04d to e47d5db Compare October 8, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants