Skip to content

feat(scripts): link each pull request in the kilo-app changelog - #6807

Merged
iscekic merged 1 commit into
mainfrom
kwf/kilo-app-changelog-pr-links
Sep 28, 2026
Merged

iscekic merged 1 commit into
mainfrom
kwf/kilo-app-changelog-pr-links

Conversation

@iscekic

@iscekic iscekic commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

The kilo-app release pipeline builds the mobile CHANGELOG.md line from the merged pull request subjects between two refs. Each line was plain text, so a reader could not open the pull request from the rendered changelog.

body now turns the trailing (#<n>) of each subject into a Markdown link to https://github.com/Kilo-Org/cloud/pull/<n>. The link keeps the original parentheses, so a line reads:

- fix(mobile): second ([#101](https://github.com/Kilo-Org/cloud/pull/101))

Only the trailing reference is a pull request number, so only the trailing reference is linked. Existing changelog sections stay byte-for-byte.

Verification

  • Ran node scripts/kilo-app-release-notes.mjs body --from HEAD~60 in this worktree and read the output: every line carries a pull request link.
  • Ran node --test scripts/kilo-app-release.test.mjs scripts/kilo-app-release-workflow.test.mjs: all pass.
  • Ran oxfmt --check and oxlint on both changed files: clean.

No user interface changes.

Visual Changes

N/A

Reviewer Notes

The write subcommand is unchanged. It writes the body output it receives, so the link reaches CHANGELOG.md through the existing path.

The changelog body lists shipped pull request subjects as plain text.
A reader cannot open the pull request from the rendered file.

Link the trailing (#<n>) of each body line to its pull request.
@iscekic iscekic self-assigned this Sep 28, 2026
@iscekic
iscekic marked this pull request as ready for review September 28, 2026 15:53
@kilo-code-bot

kilo-code-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • scripts/kilo-app-release-notes.mjs
  • scripts/kilo-app-release.test.mjs

Notes

  • PR_SUBJECT_RE gains a capture group only; isPullRequestSubject still uses a non-global .test(), so its semantics are unchanged.
  • linkPullRequest uses a non-global String.replace with an end-anchored regex, so only the trailing (#<n>) is linked; subjects without a trailing ref are returned unchanged, which the new test covers.
  • The generated link is consumed only by write, which stores the body verbatim in apps/mobile/CHANGELOG.md (.github/workflows/kilo-app-release.yml:574); nothing parses the line expecting plain text.
  • insertSection and all older changelog content remain untouched, so existing sections stay byte-for-byte.

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic enabled auto-merge (squash) September 28, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants