Skip to content

fix(mobile): name findings signalements in the French queued toast - #6754

Merged
iscekic merged 1 commit into
mainfrom
kwf/janitor-mobile-security-agent-5dc489b49a
Sep 28, 2026
Merged

iscekic merged 1 commit into
mainfrom
kwf/janitor-mobile-security-agent-5dc489b49a

Conversation

@iscekic

@iscekic iscekic commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Changelog for users

  • French users now read signalements, not problèmes, in the automation queued-analysis toast.
  • The many-count French toast now reads signalements instead of vulnérabilités.

Changelog for maintainers

  • The French queued and queued_other forms now share the catalog term already used by queued_one.
  • Review the whole queued key family and the other locales for the same term drift.

E2E proof

The counted securityAgent.automation.queued toast names the same finding 'problèmes', 'signalement' and 'vulnérabilités' across its plural forms, contradicting the catalog's term 'signalement' for a finding.

Code trace: apps/mobile/src/i18n/locales/fr.json:1126 changed in 764792968dba3149c1143923883089c0d1098b77. Sense check (model): the diff's "queued_many" line now reads "... signalements existants ...", matching the catalog term across all three plural forms named in the trace

Changed lines
-      "queued": "{{displayCount}} problèmes déjà détectés ont été mis en file d'attente pour analyse.",
-      "queued_other": "{{displayCount}} problèmes déjà détectés ont été mis en file d'attente pour analyse.",
+      "queued": "{{displayCount}} signalements déjà détectés ont été mis en file d'attente pour analyse.",
+      "queued_other": "{{displayCount}} signalements déjà détectés ont été mis en file d'attente pour analyse.",
-      "queued_many": "{{displayCount}} vulnérabilités existantes mises en attente d'analyse."
+      "queued_many": "{{displayCount}} signalements existants mis en attente d'analyse."
Owner request

Fix 1 janitor finding in mobile/security-agent. Fix every one; the proof covers each.

  1. The counted securityAgent.automation.queued toast names the same finding 'problèmes', 'signalement' and 'vulnérabilités' across its plural forms, contradicting the catalog's term 'signalement' for a finding.
    Trace: apps/mobile/src/i18n/locales/fr.json:1126: The counted securityAgent.automation.queued toast names the same finding 'problèmes', 'signalement' and 'vulnérabilités' across its plural forms, contradicting the catalog's term 'signalement' for a finding. (janitor area i18n, locale fr).
    Files: apps/mobile/src/i18n/locales/fr.json.

@iscekic iscekic added the kwf-janitor Admitted to the workflow from a janitor finding label Sep 26, 2026
@kilo-code-bot

kilo-code-bot Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • apps/mobile/src/i18n/locales/fr.json

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 26, 2026
@iscekic iscekic self-assigned this Sep 26, 2026
@iscekic iscekic added merge-by-human the merge bot routed this PR to a human merge-by-bot and removed merge-by-human the merge bot routed this PR to a human human-ready The PR is ready for human review. labels Sep 26, 2026
@iscekic
iscekic marked this pull request as draft September 28, 2026 08:40
@iscekic
iscekic marked this pull request as ready for review September 28, 2026 08:44
@iscekic
iscekic marked this pull request as draft September 28, 2026 08:52
@iscekic
iscekic marked this pull request as ready for review September 28, 2026 09:01
@iscekic
iscekic marked this pull request as draft September 28, 2026 09:05
@iscekic
iscekic marked this pull request as ready for review September 28, 2026 09:10
@iscekic
iscekic marked this pull request as draft September 28, 2026 09:21
@iscekic
iscekic marked this pull request as ready for review September 28, 2026 09:28
@iscekic
iscekic merged commit a8f038f into main Sep 28, 2026
29 checks passed
@iscekic
iscekic deleted the kwf/janitor-mobile-security-agent-5dc489b49a branch September 28, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kwf-janitor Admitted to the workflow from a janitor finding merge-by-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants