Skip to content

fix(mobile): centre the tour eyebrow above the step heading - #6713

Merged
iscekic merged 5 commits into
mainfrom
kwf/explorer-home-quick-tour-the-all-caps-quick-tour-label-is-70bef-fd08
Sep 25, 2026
Merged

iscekic merged 5 commits into
mainfrom
kwf/explorer-home-quick-tour-the-all-caps-quick-tour-label-is-70bef-fd08

Conversation

@iscekic

@iscekic iscekic commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Changelog for users

  • On the first-sign-in tour, the “QUICK TOUR” label appears centered directly above the step heading.
  • The label no longer sits alone at the top-left with a large gap above the content.

Changelog for maintainers

  • TourStepHeader takes a required eyebrow and renders it centered between the icon tile and the h3 title, under the shared tour font-scale cap.
  • The active tour step passes t("tour.eyebrow"); ScreenHeader keeps its modal spacing but receives no eyebrow.
  • Mounted tests assert that the eyebrow belongs to the step header, not the screen header, and shares the tour font-scale cap.
  • No i18n catalog change; the existing tour.eyebrow key is reused.

Verification

  • Local tests, builds, app runs, and device checks were not run, as requested.
  • Remote checks before this push: Kilo Code Review passed; CodeSmith skipped. No test or build checks were reported.

…plorer-home-quick-tour-the-all-caps-quick-tour-label-is-70bef-fd08/s1)
@kilo-code-bot

kilo-code-bot Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental re-review of the tour eyebrow relocation found no new issues: the required eyebrow prop is supplied at the fork step, the existing tour.eyebrow catalog key is reused, and the updated mounted tests match the rendered output.

Files Reviewed (4 files)
  • apps/mobile/src/components/tour/tour-step-header.tsx
  • apps/mobile/src/components/tour/tour-screen.tsx
  • apps/mobile/src/components/tour/tour-step-header.mounted.test.tsx
  • apps/mobile/src/components/tour/tour-screen.mounted.test.tsx
Previous Review Summary (commit 884dccc)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 884dccc)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • apps/mobile/src/components/tour/tour-step-header.tsx
  • apps/mobile/src/components/tour/tour-screen.tsx
  • apps/mobile/src/components/tour/tour-remote-step.tsx
  • apps/mobile/src/components/tour/tour-step-header.mounted.test.tsx
  • apps/mobile/src/components/tour/tour-screen.mounted.test.tsx
  • apps/mobile/src/components/tour/tour-remote-step.mounted.test.tsx

Verified that the new required eyebrow prop is supplied by both real call sites, the existing tour.eyebrow i18n key is reused (no catalog change needed), Eyebrow forwards maxFontSizeMultiplier and className through to Text, and the ScreenHeader no longer receiving eyebrow is consistent with its optional prop. No memory-leak surface was introduced (no new subscriptions, listeners, or queries).


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants