Skip to content

Revert "feat(mobile): render native iOS 26 Liquid Glass in BlurBar (#6621)" - #6664

Merged
iscekic merged 1 commit into
mainfrom
revert/pr-6621-liquid-glass
Sep 23, 2026
Merged

iscekic merged 1 commit into
mainfrom
revert/pr-6621-liquid-glass

Conversation

@iscekic

@iscekic iscekic commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Reverts #6621.

What this removes

  • Removes the expo-glass-effect dependency from apps/mobile/package.json.
  • Restores BlurBar to the expo-blur implementation, with no GlassView branch.
  • Removes the Liquid Glass unit tests from blur-bar.test.ts.
  • Returns the expo-glass-effect release-age exemption to 57.0.2 in pnpm-workspace.yaml and the policy test.
  • Updates pnpm-lock.yaml to resolve expo-glass-effect@57.0.2 as a transitive dependency of expo only.

Verification

  • The revert is the byte-identical inverse of the PR 6621 diff.
  • rg finds no GlassView, isLiquidGlassAvailable, or isGlassEffectAPIAvailable references under apps/mobile/src.
  • git diff --check is clean.

@iscekic iscekic self-assigned this Sep 23, 2026
@kilo-code-bot

kilo-code-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the revert of #6621 (Liquid Glass in BlurBar): the diff is a clean, scoped inverse that restores the pre-#6621 source byte-for-byte, with no dangling glass references and consistent release-age exemptions.

Verification Performed

  • Confirmed blur-bar.tsx, blur-bar.test.ts, minimum-release-age-policy.test.ts, and apps/mobile/package.json are byte-identical to the state before 823f66c38 (git diff 823f66c38^ 0082a7ce3 -- <files> is empty).
  • Confirmed pnpm-workspace.yaml only reverts the expo-glass-effect exemption line; unrelated later dependency-remediation entries are preserved.
  • Confirmed no remaining GlassView, isLiquidGlassAvailable, isGlassEffectAPIAvailable, or glassEffectStyle references under apps/mobile.
  • Confirmed the lockfile resolves expo-glass-effect@57.0.2 as a transitive dependency and the minimumReleaseAgeExclude entry matches that exact version.
Files Reviewed (4 files)
  • apps/mobile/package.json
  • apps/mobile/src/components/ui/blur-bar.test.ts
  • apps/mobile/src/components/ui/blur-bar.tsx
  • apps/mobile/src/lib/minimum-release-age-policy.test.ts
  • pnpm-workspace.yaml
  • pnpm-lock.yaml (generated, skipped)

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic enabled auto-merge (squash) September 23, 2026 21:22
@iscekic
iscekic merged commit 1f36f6a into main Sep 23, 2026
81 checks passed
@iscekic
iscekic deleted the revert/pr-6621-liquid-glass branch September 23, 2026 21:34
iscekic added a commit that referenced this pull request Sep 25, 2026
The Liquid Glass BlurBar that imported expo-glass-effect was reverted on main
(#6664), so the package has no importer left and `pnpm --filter kilo-app run
check:unused` (knip) fails on it.

Remove the direct dependency and its pnpm-lock importer entry. The
minimumReleaseAge exemption stays: expo-router still resolves
expo-glass-effect@57.0.3 transitively, so the version must remain allowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants