Repository navigation
(janitor/dead-code): delete dead mcp-gateway routes.schema re-export - #6632
Merged
kilo-code-bot[bot] merged 1 commit intoSep 25, 2026
Merged
Conversation
services/mcp-gateway/src/schemas/routes.schema.ts only re-exports route param schemas from @kilocode/mcp-gateway and has no importers, side effects, or config references. Handlers already import these schemas directly from the package.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummarySingle-file dead-code deletion of an unreferenced 6-line re-export; repository-wide search confirms no importers, and remaining consumers import these schemas directly from Files Reviewed (1 file)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 25, 2026
kilo-code-bot
Bot
deleted the
janitor/dead-code-mcp-gateway-routes-schema
branch
September 25, 2026 15:55
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was deleted
services/mcp-gateway/src/schemas/routes.schema.ts— a single 6-line file that only re-exportedUserConnectRouteParamsSchema,OrgConnectRouteParamsSchema, and their inferred types from@kilocode/mcp-gateway. Its parentsrc/schemas/directory was also removed (now empty).Evidence it was unreachable
routes.schema,schemas/routes, and the re-exported symbols found zero references outside the file itself (ripgrep overservices/,packages/,apps/,scripts/,dev/, and all config files).services/mcp-gateway/src/handlers/connect.handler.tsandservices/mcp-gateway/src/handlers/protected-resource.handler.ts— import them directly from@kilocode/mcp-gateway, not from this file.feat(mcp-gateway): implement OAuth runtime gateway (#3717); it is a pure re-export with no module-level side effects, so deleting it cannot remove any initialization or behavior.Dynamic and configured entry points checked
src/mcp-gateway.worker.ts(wrangler.jsoncmain); it does not importschemas/.wrangler.jsoncbindings, Durable Objects, queues, cron triggers, alarms, RPC, or migrations reference the file (onlyMCPGatewayInstanceDO andv1SQLite migration, both unrelated).services/mcp-gateway/package.jsonhas noexports/filesmap referencing it.tsconfig.jsonincludeis a broadsrc/**/*.tsglob, not a per-file reference.import()orrequire()references it.Contract and compatibility considerations
@kilocode/mcp-gatewaypackage still exports the schemas fromsrc/routes.tsvia itsindex.ts; no public contract is changed.Validation performed
pnpm --filter cloudflare-mcp-gateway run typecheck— clean before and after.pnpm --filter cloudflare-mcp-gateway run test— 18 passed before and after.pnpm --filter cloudflare-mcp-gateway run lint— 0 warnings / 0 errors.git diff --check— clean.