Repository navigation
LOST-WORKSPACE: disable control snapshots and restore control commit path - #6622
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| finalization: { | ||
| ...metadata.finalization, | ||
| ...input.finalization, | ||
| autoCommit: input.finalization?.autoCommit ?? metadata.finalization?.autoCommit ?? true, |
There was a problem hiding this comment.
SUGGESTION: The new auto-commit default is applied only at admission, not when legacy queued messages are frozen.
This default now covers non-worktree control sessions at admission, but the three sibling sites that freeze legacy queued rows still gate the default finalization on a worktree: latestMetadata.workspace?.worktreeId ? latestMetadata.finalization : undefined at lines 3489 and 3535, and metadata.workspace?.worktreeId ? metadata.finalization : undefined at line 3613. A legacy queued row in a non-worktree control session is therefore frozen with no finalization, and the wrapper falls back to autoCommit ?? false (services/cloud-agent-next/wrapper/src/server.ts:540), so that turn still never commits — the same lost-work gap this PR closes for newly admitted messages. The updated integration expectation at test/integration/sandbox-control.test.ts:11510 documents this asymmetry (frozen legacy intents have no finalization, while msg_new_b gets autoCommit: true). Consider supplying the same default in those freeze paths for consistency.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe rebased PR content is unchanged from the prior review; the control-session auto-commit default is applied only at admission, while legacy queued rows frozen later in non-worktree sessions still bypass it, leaving a residual lost-work path. Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit 4224829)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 4224829)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe control-session auto-commit default is correct at admission, but legacy queued rows frozen later in non-worktree sessions still bypass it, leaving a residual lost-work path. Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (5 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
…commit path The control-plane Kilo config now sets snapshot: false, matching the legacy builder's intent that no Cloud Agent session runs Kilo's snapshot feature. The SandboxSession admission gate no longer requires a worktree: a control session without one now defaults per-turn autoCommit to true, so its work is committed (and pushed when a remote is reachable) at successful turn completion instead of having no durable home. LOST-WORKSPACE
4224829 to
4bcad3d
Compare
Summary
snapshot: false(buildWorktreeKiloEnvironment,services/cloud-agent-next/wrapper/src/control/worktree-runtime.ts), matching the legacy builder's intent that no Cloud Agent session runs Kilo's snapshot feature.SandboxSessionadmission default no longer requires a worktree, so a control session without one defaults per-turnautoCommittotrueand its work is committed (and pushed when a remote is reachable) at successful turn completion.Tests
Base branch:
triage/attach-reclaim.