Repository navigation
fix(mobile): keep new-session mode and model pills above the keyboard - #6487
Conversation
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe incremental changes since Overview
Issue Details (click to expand)SUGGESTION
Both items carry active inline comments from the prior review and remain unresolved; no new inline comments were posted. Files Reviewed (16 files)
Fix these issues in Kilo Cloud Previous Review Summaries (4 snapshots, latest commit cae45fb)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit cae45fb)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryNo new issues in the incremental changes since Overview
Issue Details (click to expand)SUGGESTION
Both items were re-verified on the current head and already carry active inline comments from the prior review, so no new inline comments were posted. Files Reviewed (9 files)
Fix these issues in Kilo Cloud Previous review (commit 916d405)Status: 3 Issues Found | Recommendation: Address before merge Executive SummaryThe composer input-height fix is intact on the current head; the two previously accepted toolbar/chrome findings are resolved, leaving three low-severity documentation and test-redundancy suggestions. Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (14 files)
Fix these issues in Kilo Cloud Previous review (commit 04113ef)Status: 3 Issues Found | Recommendation: Address before merge Executive SummaryThe composer input-height fix and both prior suggestions are resolved; the remaining findings are three low-severity documentation and test-redundancy issues on lines added since the last review. Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (changed since the last review)
Fix these issues in Kilo Cloud Previous review (commit cce350d)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (11 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
c93d08f to
04113ef
Compare
94c18bb to
916d405
Compare
|
bot: rejected: a suggestion, not a defect. A typed review read 2 of these findings as needing no code change before merge; the code stays as is. Say so here if one of them does change behaviour and it will be repaired.
|
f2f5ef5 to
cae45fb
Compare
e7fe0b6 to
b2a2ca9
Compare
Changelog for users
Changelog for maintainers
resolveNewSessionPromptCardChromeRowsAboveToolbaradds the attachment strip (72), the metadata-failure notice (24), and the near-limit counter (20) to the fixed rows, and the resolver applies each under the same condition the card renders it.nullthat selects the static budget), andresolveNewSessionPromptCardChrometreats a missing, zero, or negative height as not measured. The models-error block, which renders in the toolbar's place, also forces the static budget viatoolbarRendered: !showsModelsError, so a previously measured wrapped toolbar cannot stand in for a row that is not there.wrapandonLayout; only the new-session prompt and its clone opt in, so the chat composer keeps its one-line row (fix(mobile): keep the composer toolbar on one line #5983).animateLayoutopt-out; the repository connect card uses it because the transition interpolates its frame against already-snapped siblings.E2E proof
Collected 2026-09-21 on the repaired build. The default-portrait captures below re-prove the empty composer and add the attachment-strip and near-limit-counter states, replacing the earlier keyboard-up captures. Owner-manual, skipped pending owner verification: the short-viewport (density 560) and large-system-text checks, because the owner assigns display geometry, zoom, and font size to manual verification; the default-portrait captures here are the automatic proof.
Owner request
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-618b/e2e-mobile-app/e1-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-618b/e2e-mobile-app/e1-ime.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-618b/e2e-mobile-app/e1-hierarchy.txt/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-618b/e2e-mobile-app/e1-kbd-down.txt/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-618b/e2e-mobile-app/e2-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-618b/e2e-mobile-app/e2-hierarchy.txt/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-618b/e2e-mobile-app/e2-ime.log