Repository navigation
fix(web): show BytePlus upstream identifier in admin revocation queue - #6051
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by grok-4.6 · Input: 62.6K · Output: 7.9K · Cached: 445.2K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Sep 10, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surface the stored BytePlus upstream identifier in the admin Pending Key Rotation
queue so staff can map inventory items to provider-side subscriptions.
Why this change is needed
The queue showed
—for the upstream identifier on every BytePlus row because therevocation query deliberately nulled the stored value for
byteplus-coding. Adminscould not map inventory items to provider-side seats, blocking manual deprovisioning
and reconciliation. Support authorized exposing the assigned username to authorized
admins.
How this is addressed
instead of nulling it for BytePlus (MiniMax Upstream Plan ID or BytePlus assigned
username), so the existing queue column is populated.
provider-side mapping; API keys remain encrypted and are never returned.
display the stored identifier, and the clauses that previously forbade BytePlus
usernames were reconciled.
Human Verification
pnpm test -- coding-plans(apps/web): 13 suites, 164 tests passed, including a newtest asserting the queue returns the stored BytePlus username to an admin.
contradiction) was resolved, and the security and logic re-reviews returned PASS.
consistent.
Reviewer Notes
Human Reviewer Flags
to display the assigned BytePlus username; 8.4 still prohibits usernames in quota
responses and logs.
the admin console (gated by
adminProcedure). This is an intentional disclosurebroadening based on product authorization.
Code Reviewer Agent
Code Reviewer Notes
byteplus-codingand returnsthe stored value for every provider.
upstreamPlanIdwas alreadystring | null, and the UI alreadyrendered
item.upstreamPlanId ?? '—'; only the alert copy changed in the client.returns it; existing coverage still asserts non-admin rejection and that raw
credentials are never returned.
addressed (out of scope).