Skip to content

fix(mobile): one Live Activity, native pull spinner, tighter spacing - #6000

Merged
iscekic merged 2 commits into
mainfrom
fix/mobile-one-live-activity-list-spacing
Sep 9, 2026
Merged

iscekic merged 2 commits into
mainfrom
fix/mobile-one-live-activity-list-spacing

Conversation

@iscekic

@iscekic iscekic commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Review and merge this PR. Assigned to @iscekic.

Cause

#5972 ended idle Live Activities with a 10-minute dismissal. After process death, ActivityKit no longer lists those ended cards, so the next start stacked a frozen card on the Lock Screen.

#5899 added RefreshProgress inside lists that already have native RefreshControl. That produced a second spinner and extra space under search and under the Home logo.

Changes

  • Idle work updates the same Live Activity. Do not end it. Do not start a second card while any instance is visible.
  • Agents lists and Home use only the native pull spinner.
  • The refresh status line takes height only on failure.
  • Home header and section spacing are tighter.

Tests

vitest on ios-sink, notifications, session-list, and home suites: 239 + 236 passed.

Idle work now updates the same Live Activity instead of ending it
with a delayed dismissal. That delayed end left ended-but-visible
cards that ActivityKit cannot rediscover after process death, so
the next start stacked a frozen card on the Lock Screen.

Remove the extra RefreshProgress header from Agents lists and Home.
Keep the native pull spinner. Drop the reserved idle status line
and tighten Home header spacing.
@iscekic iscekic self-assigned this Sep 9, 2026
@kilo-code-bot

kilo-code-bot Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of the unused-async Live Activity test cleanup on HEAD 1c0b73d; prior 12-file review still stands with high confidence.

Files Reviewed (12 files)
  • apps/mobile/src/components/agents/session-list-content.tsx
  • apps/mobile/src/components/agents/session-list-refresh-status.tsx
  • apps/mobile/src/components/agents/session-list-screen.tsx
  • apps/mobile/src/components/home/home-screen.tsx
  • apps/mobile/src/components/home/section-header.tsx
  • apps/mobile/src/components/tab-screen.tsx
  • apps/mobile/src/glanceable-ios/ending-activities.ts
  • apps/mobile/src/glanceable-ios/ios-sink.native.test.ts
  • apps/mobile/src/glanceable-ios/ios-sink.test.ts
  • apps/mobile/src/glanceable-ios/ios-sink.ts
  • apps/mobile/src/lib/notifications.test.ts
  • apps/mobile/src/lib/notifications.ts
Previous Review Summary (commit ed76960)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit ed76960)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (12 files)
  • apps/mobile/src/components/agents/session-list-content.tsx
  • apps/mobile/src/components/agents/session-list-refresh-status.tsx
  • apps/mobile/src/components/agents/session-list-screen.tsx
  • apps/mobile/src/components/home/home-screen.tsx
  • apps/mobile/src/components/home/section-header.tsx
  • apps/mobile/src/components/tab-screen.tsx
  • apps/mobile/src/glanceable-ios/ending-activities.ts
  • apps/mobile/src/glanceable-ios/ios-sink.native.test.ts
  • apps/mobile/src/glanceable-ios/ios-sink.test.ts
  • apps/mobile/src/glanceable-ios/ios-sink.ts
  • apps/mobile/src/lib/notifications.test.ts
  • apps/mobile/src/lib/notifications.ts

Reviewed by grok-4.6 · Input: 64.5K · Output: 5.1K · Cached: 150.9K

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants